fix(game/five): updateBusySpinner thread constraint check #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work as a temporary fix to prevent crashes when for unknown reasons 'updateBusySpinner' gets called from the Render thread instead of the Main thread, which causes an inner function call to return a nullptr. due to failing thread constraint checks.
github-actions
bot
added
the
triage
|
Any plans to get this reviewed ? We're having new players reporting this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Prevent crashes caused by reading from a nullptr when
updateBusySpinneris called from the Render thread.How is this PR achieving the goal
Although the root cause of this issue requires further investigation, this PR provides a temporary fix to prevent crashes when
updateBusySpinneris unexpectedly called from the Render thread instead of the Main thread. This call causes a subsequent function to return a nullptr due to failing thread constraint checks in native game code.The only potential side effect of this fix is missing updates to the busy spinner during the loading of addon data files, but this is still better than outright crashing.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 3258
Platforms: Windows (Client)
Checklist
Fixes issues
fixes #2850