From 297ce130e5c29afd081cd218b7f4f8107490d537 Mon Sep 17 00:00:00 2001 From: Jeremy Frasier Date: Tue, 21 May 2024 10:08:34 -0400 Subject: [PATCH] Modify the ansible-core pin to ensure a good version is used We can do this because new versions of ansible-core (2.16.7 and 2.17.0) have been released that do not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. All versions later than ansible-core 2.16.7 and 2.17.0 should function as expected. --- requirements.txt | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/requirements.txt b/requirements.txt index ec3e967..bdf26b2 100644 --- a/requirements.txt +++ b/requirements.txt @@ -13,19 +13,15 @@ # often breaking changes across major versions. This is the reason # for the upper bound. ansible>=8,<10 -# TODO: Remove this pin when possible. See -# cisagov/skeleton-packer#312 for more details. -# -# ansible-core 2.16.3 and later suffer from the bug discussed in +# ansible-core 2.16.3 through 2.16.6 suffer from the bug discussed in # ansible/ansible#82702, which breaks any symlinked files in vars, # tasks, etc. for any Ansible role installed via ansible-galaxy. +# Hence we never want to install those versions. # -# See also cisagov/skeleton-ansible-role#178 and -# cisagov/skeleton-generic#180. Note from these PRs that any changes -# made to this dependency must also be made in requirements-test.txt -# in cisagov/skeleton-ansible-role and .pre-commit-config.yaml in -# cisagov/skeleton-generic. -ansible-core<2.16.3 +# Note that any changes made to this dependency must also be made in +# requirements-test.txt in cisagov/skeleton-ansible-role and +# .pre-commit-config.yaml in cisagov/skeleton-generic. +ansible-core>=2.16.7 boto3 docopt semver