Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Export Printing of All Domains/All Vulnerabilities Tables #326

Open
hawkishpolicy opened this issue Jun 6, 2024 · 2 comments
Open
Assignees
Labels

Comments

@hawkishpolicy
Copy link
Collaborator

🐛 Summary

What's wrong? Please be specific.

Default formatting prevents all columns from being displayed when attempting to print results from table.

To reproduce

Steps to reproduce the behavior:

  1. Click Export in Data Grid Toolbar
  2. Select Print
  3. Examine Print Dialogue

Expected behavior

What did you expect to happen that didn't?

Either wrap columns or adjust font and spacing to include all columns in at least landscape mode.

Any helpful log output or screenshots

Add any screenshots of the problem here.
Screenshot 2024-06-06 at 9 14 01 AM
Screenshot 2024-06-06 at 9 14 32 AM

@hawkishpolicy hawkishpolicy self-assigned this Jun 6, 2024
@hawkishpolicy
Copy link
Collaborator Author

Here are some considerations following testing of and experimenting with possible solutions:

  1. It may be misguided to code print export configurations given the following:
  • The wide range of possible printing preferences depending on the user, i.e. page layout and paper size.
  • The wide range of columns the user decides to print, i.e. they may not need to print the full table.
  1. Chrome's print dialogue is sufficient to scale the grid to portrait or landscape layout and offers multiple page sizes.
  • Other browser's need to be tested.

If other browser's follow suit, this issue should be closed with stock behavior intact.

Below are screenshots of the scaled print preview, both portrait and landscape, using Chrome's print dialog:

Screenshot 2024-06-10 at 1 33 29 PM
Screenshot 2024-06-10 at 1 33 51 PM

@hawkishpolicy
Copy link
Collaborator Author

Safari print dialogue scales appropriately:

Screenshot 2024-06-10 at 3 47 29 PM Screenshot 2024-06-10 at 3 47 43 PM

But safari does not:

Screenshot 2024-06-10 at 3 52 33 PM Screenshot 2024-06-10 at 3 54 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant