Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify workflow code to use functions instead of modules #1429

Open
1 task
james-garriss opened this issue Nov 15, 2024 · 0 comments · May be fixed by #1430
Open
1 task

Modify workflow code to use functions instead of modules #1429

james-garriss opened this issue Nov 15, 2024 · 0 comments · May be fixed by #1430
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@james-garriss
Copy link
Collaborator

💡 Summary

In talking with Addam, we have decided that the ideal pattern for workflow code (in /utils/workflow) is to be in functions in .ps1 files. This issue is to modify two files to this form:

  • Initialize-ScubaGearForTesting
  • Install-SeleniumForTesting

Motivation and context

Reduces technical debt and improves quality of workflow testing.

Implementation notes

Convert files to .ps1
Make sure all code is in functions
Make sure code still works
Make sure unit testing still works

Acceptance criteria

How do we know when this work is done?

  • Code works and is tested
@james-garriss james-garriss self-assigned this Nov 15, 2024
@james-garriss james-garriss added the enhancement This issue or pull request will add new or improve existing functionality label Nov 15, 2024
@james-garriss james-garriss added this to the Kraken milestone Nov 15, 2024
@james-garriss james-garriss linked a pull request Nov 15, 2024 that will close this issue
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant