Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Vulnerabilities #79

Open
VICINDY19 opened this issue Nov 29, 2022 · 0 comments
Open

Security Vulnerabilities #79

VICINDY19 opened this issue Nov 29, 2022 · 0 comments

Comments

@VICINDY19
Copy link

After conducting a security vulnerability analysis on the package, I noticed two opportunities for security vulnerabilities to make its way into applications when this package is being utilized. The first is the fact that sanitizing the input is optional with the 'sanitizeHtml' prop only seeming to work properly on rare cases. Since this is not a default behavior, even just a bare bones, simple sanitization, it can lead way to cross-site scripting. Furthermore, there is no way to check if the sanitizeHtml prop is in fact a sound function for sanitization and not a type of malicious function being passed in. While we do not want to restrict the user and also it would defeat the purpose of the translation. At least sanitizing the initial markdown input so if any HTML is inputted in it, it should not make way into the produced HTML, as only plain markdown text should. This would adhere to the intentional functionality of the package while making it safer to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant