Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to the Wiki not behaving as expected #370

Open
Mostelin opened this issue Dec 6, 2024 · 8 comments
Open

Link to the Wiki not behaving as expected #370

Mostelin opened this issue Dec 6, 2024 · 8 comments
Labels
documentation Improvements or additions to documentation

Comments

@Mostelin
Copy link

Mostelin commented Dec 6, 2024

On the Adaptation tab there is a link to a relevant page in the Knobkraft Wiki. On my system this links to the Ensoniq ESQ-1 page using the following url:

https://github.com/christofmuc/KnobKraft-orm/wiki/Ensoniq-ESQ-1

The odd thing is that, while this appears to be the correct url, the Wiki does not display the page, but instead suggests the user 'Create new page'.

I suspect this is a relatively new issue, as memory tells me this used to work as expected. I suspect it is getting confused by the '-' characters in the string.

@christofmuc
Copy link
Owner

Thanks for reporting!

This is funky.

When I visit the page with my browser and copy the URL from the browser address bar into notepad, I see:

https://github.com/christofmuc/KnobKraft-orm/wiki/Ensoniq-ESQ%E2%80%901

which is Unicode encoding. Asking ChatGPT:

"The strange part of the URL, %E2%80%901, is a UTF-8 encoded character. Let me decode it for you.
Decoding %E2%80%901

The sequence %E2%80%90 represents the Unicode character U+2010, which is the Hyphen (‐). It's a typographically correct hyphen and differs from a simple ASCII hyphen-minus (-).
Decoded URL

The full decoded URL is:

https://github.com/christofmuc/KnobKraft-orm/wiki/Ensoniq-ESQ‐1

Here, the "‐" is a proper hyphen. If you copy this decoded link, it should work the same as the original URL."

So github has converted our Wiki page into a page with a hyphen, not a minus. Looks the same, but I would be surprised if we have created the page with a hyphen originally.

@christofmuc christofmuc added the bug Something isn't working label Dec 13, 2024
@christofmuc
Copy link
Owner

Lol, Gitlab has the same problem, but they have documented the workaround: https://gitlab.com/gitlab-org/gitlab-foss/-/issues/43795

@christofmuc
Copy link
Owner

Maybe we created it ourselves after all: https://stackoverflow.com/questions/77244370/linking-to-a-page-with-a-dash-hyphen-in-the-title-in-github-wiki

I think the best solution would be to assume it is a Unicode hyphen character, and fix the link in the KnobKraft software. We need to check though if all pages have this problem.

@Mostelin
Copy link
Author

Thanks for investigating. There's nothing I can do to help, by the looks of it.

@christofmuc
Copy link
Owner

This is even weirder. I now create the page with the normal dash instead of the unicode hyphen, intending to move your doc into the page that is linked from the software.

But the page I just created already has a long history of your edits:
https://github.com/christofmuc/KnobKraft-orm/wiki/Ensoniq-ESQ-1/_history

I think on May 26 some github code ran and changed the title of the page to the real hyphen instead of the dash we had before. And it lost all history of that page before, because that was stored under the dash address, which I now reactivated by recreating the page.

Would you mind to move the content over to the dash address, then we can redirect the hyphen page to the dash page, and the link in the software is correct again?

@christofmuc
Copy link
Owner

Ah, or it was your own edit on May 26: Maybe you changed the title from "Ensoniq ESQ 1" to "Ensoniq ESQ-1", and github change the link of the page to include the hypen. Because the space in the original title is converted to a dash in the URL. I think we should move your content and keep the space in the title, even if it is incorrect. But the link will work.

@christofmuc christofmuc added documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 15, 2024
@Mostelin
Copy link
Author

If using the title 'Ensoniq ESQ 1' fixes the problem, then let's do that. It is a typographically incorrect title, but everyone will know what it refers to.

@Mostelin
Copy link
Author

I think I overlooked your question - no, I don't object to changing to using the typographical dash in place of the hyphen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants