Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Album sort should account for disk number if present #229

Open
AntiSol opened this issue Oct 2, 2024 · 1 comment
Open
Labels
Enhancement New feature or request Postponed just put it aside for a while (?)

Comments

@AntiSol
Copy link

AntiSol commented Oct 2, 2024

Hello, thanks for phonograph!

If there's an id3v2 disk number field present and populated, this should be taken into account when sorting tracks in an album, i.e all tracks from disk 1 should be shown before showing track 1 from disk 2.

image
image

@AntiSol AntiSol added the Enhancement New feature or request label Oct 2, 2024
@chr56
Copy link
Owner

chr56 commented Oct 2, 2024

For current infrastructures, it is hard to implement it.

Since Android R (11)1, MediaStore of OS can support read and store DISC_NUMBER; before that2, we have to scan the file to gain it (like Song Detail you displayed).

Phonograph Plus supports from Android N. To implement this feature, you can:

  1. Make two implementations, one for Android R and above with this feature, another for Android Q and below without this feature. This would increase the complexity and the cost of maintainability, and give some users up, like you. I choose NO.
  2. Scan all files, reading their tags and store them. There would plenty of works to do, for changing entire infrastructures. I prefer this, and it's what I currently do (for about 2 years, but requires more time to get completely finished. There has been a lot of problems since entire Phonograph Plus roots deeply on the old infrastructures that directly reading from MediaStore, resulting "smooth migrating" to the new infrastructures really hard and painful).

So, please wait for it.

Footnotes

  1. Source of MediaStore on Android R

  2. Source of MediaStore on Android Q

@chr56 chr56 added the Postponed just put it aside for a while (?) label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Postponed just put it aside for a while (?)
Projects
None yet
Development

No branches or pull requests

2 participants