Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies #109

Open
MehtapIsik opened this issue Jun 16, 2017 · 4 comments
Open

Missing dependencies #109

MehtapIsik opened this issue Jun 16, 2017 · 4 comments

Comments

@MehtapIsik
Copy link
Contributor

While installing assaytools in a Python 3.5 environment I noticed some dependencies are missing. I had to install lxml, seaborn and pymc separately after running python setup.py install.

I noticed that those missing dependencies are actually listed in setup.py, but commented out: https://github.com/choderalab/assaytools/blob/master/setup.py#L87

I want to activate those lines so that these dependencies are also installed at setup.

@MehtapIsik
Copy link
Contributor Author

@sonyahanson @jchodera Do you have any reservations about this change?

@jchodera
Copy link
Member

These packages are not all pip-installable. If you uncomment them, you will no longer be able to install assaytools via python setup.py install because it will try (and fail) to install them by pip if you do not have them already installed.

We do have these listed in the conda package requirements, which is why we recommend people install this tool via conda. We haven't cut a release in quite some time, however.

@MehtapIsik
Copy link
Contributor Author

@jchodera Thanks for explaining why those are commented out.

Do your recommend installing through conda and uninstalling to just get dependencies, and then installing assaytools from repository via python setup.py install ?

When I tried conda installing assaytools with conda, it gives an error about Python 3.5 incompatibility.

$ conda install assaytools
Fetching package metadata .............
Solving package specifications: .

UnsatisfiableError: The following specifications were found to be in conflict:
  - assaytools -> python 2.7*
  - python 3.5*
Use "conda info <package>" to see the dependencies for each package.

I think we must update the conda release, so that it at least works with Python 3.5.

@jchodera
Copy link
Member

Do your recommend installing through conda and uninstalling to just get dependencies, and then installing assaytools from repository via python setup.py install ?

Yes!

When I tried conda installing assaytools with conda, it gives an error about Python 3.5 incompatibility.

It looks like we haven't cut a new release since Python 3.5 was added. Let's create a new assaytools release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants