-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chembl prior centered around 0? #105
Comments
Nope. It's a fit to the ChEMBL distribution of assay data. |
Sorry, could you explain a bit more how a fit to ChEMBL data happens from this line of code? DeltaG = pymc.Normal('DeltaG', mu=0, tau=1./(12.5**2)) |
This is not really meant for production, so we should deprecate it. I simply took the distribution of affinity data in ChEMBL from one of Christian Kaiser's papers (the same one in Figure 6 of my review on entropy-enthalpy compensation) and fit a Gaussian to it. Those are the parameters of the Gaussian. |
Hm, but they should be centered closer to -10 kcal/mol. So let's ditch this prior. |
Could we just change the mu to be closer to that of the meta-analysis? I'd be interested to see how a different prior effects our results. |
Is the chembl prior centered around 0? If so, this seems wrong and we should adjust accordingly if we ever plan to use this: https://github.com/choderalab/assaytools/blob/master/AssayTools/pymcmodels.py#L372
Currently we generally use the uniform prior, so this hasn't been an issue thus far...
The text was updated successfully, but these errors were encountered: