Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chembl prior centered around 0? #105

Open
sonyahanson opened this issue May 30, 2017 · 5 comments
Open

Chembl prior centered around 0? #105

sonyahanson opened this issue May 30, 2017 · 5 comments

Comments

@sonyahanson
Copy link
Contributor

Is the chembl prior centered around 0? If so, this seems wrong and we should adjust accordingly if we ever plan to use this: https://github.com/choderalab/assaytools/blob/master/AssayTools/pymcmodels.py#L372

Currently we generally use the uniform prior, so this hasn't been an issue thus far...

@jchodera
Copy link
Member

Is the chembl prior centered around 0?

Nope. It's a fit to the ChEMBL distribution of assay data.

@sonyahanson
Copy link
Contributor Author

Sorry, could you explain a bit more how a fit to ChEMBL data happens from this line of code?

DeltaG = pymc.Normal('DeltaG', mu=0, tau=1./(12.5**2))

@jchodera
Copy link
Member

jchodera commented Jun 1, 2017

This is not really meant for production, so we should deprecate it.

I simply took the distribution of affinity data in ChEMBL from one of Christian Kaiser's papers (the same one in Figure 6 of my review on entropy-enthalpy compensation) and fit a Gaussian to it. Those are the parameters of the Gaussian.

@jchodera
Copy link
Member

jchodera commented Jun 1, 2017

Hm, but they should be centered closer to -10 kcal/mol. So let's ditch this prior.

@sonyahanson
Copy link
Contributor Author

Could we just change the mu to be closer to that of the meta-analysis? I'd be interested to see how a different prior effects our results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants