Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

install_user_app() code #407

Open
chasemc opened this issue Dec 8, 2020 · 1 comment
Open

install_user_app() code #407

chasemc opened this issue Dec 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@chasemc
Copy link
Owner

chasemc commented Dec 8, 2020

Here is where it breaks:

`
my_package_name <- electricShine::install_user_app(library_path = library_path ,
repo_location = "local",
repo = local_package_path,
repos = cran_like_url,
package_install_opts = package_install_opts)
}

Transfer icons if present -----------------------------------------------

electron_build_resources <- system.file("extdata",
"icon",
package = my_package_name,
lib.loc = library_path)`

Because electricShine::install_user_app can only return a NULL as it just gives the result of readLines() on a newly created tempfile?

I'm happy to help make this thing a reality, but, the code in install_user_app is really confusing. Like, are all of the environment variables just being used to prevent you from having to pass variables between functions?

Originally posted by @BenWiseman in #368 (comment)

@chasemc
Copy link
Owner Author

chasemc commented Dec 8, 2020

Code needs better documentation.

The variables are the only way to make R install packages in the correct location

@chasemc chasemc added the enhancement New feature or request label Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant