Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tiledbsoma version on builder to 1.12.3 #1243

Open
ivirshup opened this issue Jul 12, 2024 · 11 comments
Open

Bump tiledbsoma version on builder to 1.12.3 #1243

ivirshup opened this issue Jul 12, 2024 · 11 comments
Assignees
Labels
blocked Issue cannot be completed due to an external dependency. effort-s P0 Priority 0 - Critical, fix ASAP!

Comments

@ivirshup
Copy link
Collaborator

No description provided.

@ivirshup ivirshup added the tech label Jul 12, 2024
@ivirshup
Copy link
Collaborator Author

@pablo-gar @ebezzi is there any particular time we should do this, or can this happen whenever?

@pablo-gar
Copy link
Contributor

The guidance here is that we should update the tiledbsoma pin of builder as soon possible after we perform an LTS data release, which just happened in July 1st.

This way there is good buffer period for testing the creation of data with 1.11 from now until the next LTS data release.

@ivirshup ivirshup self-assigned this Jul 24, 2024
@ivirshup ivirshup changed the title Bump tiledbsoma version on builder to 1.11 Bump tiledbsoma version on builder to 1.11.4 Jul 24, 2024
@ivirshup
Copy link
Collaborator Author

I couldn't remember why we said to bump to 1.11 when 1.12 is out. After a brief convo with @ebezzi we determined it's because:

  • The last release of the client library was pinned to 1.11.4
  • The storage representation of tiledbsoma isn't stable between minor versions. So we need to pin the builder always needs to be <= currently released client.

@ivirshup
Copy link
Collaborator Author

ivirshup commented Jul 24, 2024

FWIW I would be up for making another minor release of census that basically just bumps the tiledbsoma version and implements the SPEC-0 dependency updates. In which case we could bump this task out a bit and go straight to 1.12 in the builder.

@johnkerl
Copy link

@ivirshup the storage version doesn't change until 1.13 / core 2.25

I had previously thought:

  • storage-version update for current domain (what core calls the new shape support) would be in 2.24
  • API for that in 2.25

But in fact the core storage version did not increment in 2.24 -- the storage-version update and the API support are both in core 2.25, which will be used in the upcoming tiledbsoma 1.13. (Although we won't fully release the new-shape feature at the TileDB-SOMA API level until 1.14.)

@ivirshup
Copy link
Collaborator Author

@johnkerl, just to be clear: you're saying that it should be safe for the builder to be on 1.12 even if the client is on 1.11?

If this is the case, how do we feel about going straight to 1.12 @pablo-gar @ebezzi?

@johnkerl
Copy link

@ivirshup correct :)

$ pwd
/Users/johnkerl/git/TileDB-Inc/TileDB

$ git diff -r 2.23.0 -r 2.24.0 format_spec/FORMAT_SPEC.md

$ git diff -r 2.24.0 -r 2.25.0 format_spec/FORMAT_SPEC.md
diff --git a/format_spec/FORMAT_SPEC.md b/format_spec/FORMAT_SPEC.md
index c4def7a9f..e7750a9b9 100644
--- a/format_spec/FORMAT_SPEC.md
+++ b/format_spec/FORMAT_SPEC.md
@@ -4,7 +4,7 @@ title: Format Specification

 **Notes:**

-* The current TileDB format version number is **21** (`uint32_t`).
+* The current TileDB format version number is **22** (`uint32_t`).
 * Data written by TileDB and referenced in this document is **little-endian**
   with the following exceptions:

@@ -36,6 +36,7 @@ title: Format Specification
 |19|2.16|[Vac files now use relative URIs](https://github.com/TileDB-Inc/TileDB/commit/ef3236a526b67c50138436a16f67ad274c2ca037)|
 |20|2.17|[Enumerations](https://github.com/TileDB-Inc/TileDB/commit/c0d7c6a50fdeffbcc7d8c9ba4a29230fe22baed6)|
 |21|2.19|[Tile metadata are now correctly calculated for nullable fixed size strings on dense arrays](https://github.com/TileDB-Inc/TileDB/commit/081bcc5f7ce4bee576f08b97de348236ac88d429)|
+|22|2.25|[Add array current domain](https://github.com/TileDB-Inc/TileDB/commit/9116d3c95a83d72545520acb9a7808fc63478963)|

@ivirshup
Copy link
Collaborator Author

Since the builder has a dependency on the client it might actually be a little difficult to get the builder running with a newer version of tiledbsoma than the client's pinned version. It might be easiest to make a quick release of the client if we go for 1.12 in the builder.

I'd be keen on this just because doing a full test of the builder takes a while and has manual steps and I'd prefer to only do this once.

@johnkerl
Copy link

All good! :)

@ivirshup ivirshup changed the title Bump tiledbsoma version on builder to 1.11.4 Bump tiledbsoma version on builder to 1.12.3 Aug 7, 2024
@ivirshup
Copy link
Collaborator Author

ivirshup commented Aug 7, 2024

Got the go ahead from @pablo-gar to just go straight to 1.12.3

@ivirshup
Copy link
Collaborator Author

ivirshup commented Aug 7, 2024

Buuuut, because the latest cellxgene-census does a hard pin on 1.11 we will have to wait for that until we make a minor release.

I think we should still merge the 1.11.4 pr since using such an old version of tiledbsoma in the builder is giving CI errors:

https://github.com/chanzuckerberg/cellxgene-census/actions/runs/10291760694/job/28484756304

@pablo-gar pablo-gar added blocked Issue cannot be completed due to an external dependency. P0 Priority 0 - Critical, fix ASAP! effort-s and removed tech labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue cannot be completed due to an external dependency. effort-s P0 Priority 0 - Critical, fix ASAP!
Projects
None yet
Development

No branches or pull requests

3 participants