Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvements #16

Open
bradroid opened this issue Jul 5, 2018 · 0 comments
Open

API improvements #16

bradroid opened this issue Jul 5, 2018 · 0 comments

Comments

@bradroid
Copy link

bradroid commented Jul 5, 2018

Hello, thanks for the nice library I have one comment.

I needed to specify the size of the dots, I needed all the dots to be the same size.

I wasn't sure which number (1-6) to use, so I used all of them:

    <com.chahinem.pageindicator.PageIndicator
        app:piSize1="10dp"
        app:piSize2="10dp"
        app:piSize3="10dp"
        app:piSize4="10dp"
        app:piSize5="10dp"
        app:piSize6="10dp"/>

This works, but I think that the you could improve your API to make it doable with 1 property/method, since this seems (to me, i might be wrong) like the most common use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant