Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apk upload to fdroid need change for new cgeo-contact addon (fix #1) #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

apk upload to fdroid need change for new cgeo-contact addon (fix #1) #2

wants to merge 3 commits into from

Conversation

bekuno
Copy link
Member

@bekuno bekuno commented Nov 22, 2019

fixes #1

@Lineflyer
Copy link
Member

If I understand correctly this will afterwards require that the contacts APK needs to added to every new release on Github, does it?

For me OK, but its a manual step, so it might be forgotten or the file name might differ each time.

Maybe we should move contacts to a dedicated repo?

@bekuno
Copy link
Member Author

bekuno commented Nov 22, 2019

With this code - yes.
What about using separate tags for the contacts plugin?
Then we can browse
https://api.github.com/repos/cgeo/cgeo/tags
and filter the latest for "market_" or "contacts_".

@Lineflyer
Copy link
Member

I am not sure how it can be done to browse and find.

Important for me is, that https://github.com/cgeo/cgeo/releases/latest is used on our website as target for apk download. Technically this always points to the newest tag, which gives a problem if we the newest tag is for contacts.

Maybe best is to store all relevant apk on download.cgeo.org or any other dedicated location.

@Lineflyer
Copy link
Member

Another thought:

How about just keeping it hardcoded for now in the script.
Most probably we wont have any new planned release of the plugin and mid term target would be to reintegrate anyway.

@bekuno bekuno mentioned this pull request Nov 23, 2019
Open
@bekuno
Copy link
Member Author

bekuno commented Nov 23, 2019

Ok, then lets for now with the dedicated plugin path.
We need the extra row
release=$(echo $apk|grep 'https\Scgeo-release-\Sapk' -o)
because "latest" contains currently also the entry for the plugin.

@Lineflyer
Copy link
Member

release=$(echo $apk|grep 'https\Scgeo-release-\Sapk' -o)
because "latest" contains currently also the entry for the plugin.

OK, this means when uploading new APK releases of the main app to Github the file name should contain "cgeo-release" then?

@bekuno
delete unnessary "-"
b89cb2e 
All latest cgeo apk packages had the name 
  cgeo-release.apk
or
  cgeo-release_XXXXXXXX.apk
(XX is the date)

In 
  https\S*cgeo-release\S*apk 
we find with \S* all non whitespace symbols. eg. current
  https://github.com/cgeo/cgeo/releases/download/market_20191111/cgeo-release.apk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apk upload to fdroid need change for new cgeo-contact addon
2 participants
@bekuno @Lineflyer