From 86cf0f5bca65b609db6d9a6a0e4249d06c84fb6c Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 12:56:26 +0100 Subject: [PATCH 01/26] Exclude some domains from link checker Relates to #318 --- .github/workflows/check_links.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 291d39ae..0bfd51bf 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -20,6 +20,8 @@ jobs: uses: actions/checkout@v2 - name: Check links uses: lycheeverse/lychee-action@v1.0.4 + with: + args: --exclude mailman.cgd.ucar.edu --exclude cfeditor.ceda.ac.uk - name: Upload report if: ${{ always() }} From 91459a13aa5166a558d386891cdfd5ba12ec9f7b Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 13:52:42 +0100 Subject: [PATCH 02/26] Only raise issue if lychee returns error --- .github/workflows/check_links.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 0bfd51bf..8e978565 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -17,6 +17,7 @@ jobs: steps: - name: Checkout + id: lychee uses: actions/checkout@v2 - name: Check links uses: lycheeverse/lychee-action@v1.0.4 @@ -31,7 +32,9 @@ jobs: path: ./lychee/out.md - name: Create Issue From File + if: env.lychee_exit_code != 0 # Only execute if check failed uses: peter-evans/create-issue-from-file@v4.0.0 + with: title: Link Checker Report content-filepath: ./lychee/out.md From 4114548f9f6a9f6284aea90a113ee76f921ce005 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 13:55:52 +0100 Subject: [PATCH 03/26] ID right step for checking non-0 status --- .github/workflows/check_links.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 8e978565..fc1277eb 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -17,9 +17,10 @@ jobs: steps: - name: Checkout - id: lychee uses: actions/checkout@v2 + - name: Check links + id: lychee uses: lycheeverse/lychee-action@v1.0.4 with: args: --exclude mailman.cgd.ucar.edu --exclude cfeditor.ceda.ac.uk From 3f7792e794cace670a89b692b82932b3dac99a23 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:07:23 +0100 Subject: [PATCH 04/26] Remove exclusion via arg --- .github/workflows/check_links.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index fc1277eb..4b359854 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -22,8 +22,6 @@ jobs: - name: Check links id: lychee uses: lycheeverse/lychee-action@v1.0.4 - with: - args: --exclude mailman.cgd.ucar.edu --exclude cfeditor.ceda.ac.uk - name: Upload report if: ${{ always() }} From ad7c01a245e174a1a408a2aa6facf2da86049e52 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:11:20 +0100 Subject: [PATCH 05/26] Pass through env variables Hopefully --- .github/workflows/check_links.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 4b359854..a79aba3c 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -29,6 +29,9 @@ jobs: with: name: Link check report path: ./lychee/out.md + env: + GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} + - name: Create Issue From File if: env.lychee_exit_code != 0 # Only execute if check failed From 8131fb1a61c2f977c65e8a853757338325683d10 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:15:36 +0100 Subject: [PATCH 06/26] Start creating issues from files again Just to see if I've restored the state as expected. If this works, I can fail from the link checker once we have the link errors gone. --- .github/workflows/check_links.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index a79aba3c..40e20cf6 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -29,14 +29,11 @@ jobs: with: name: Link check report path: ./lychee/out.md - env: - GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - + # fail: true # fail job if no go - name: Create Issue From File - if: env.lychee_exit_code != 0 # Only execute if check failed + #if: env.lychee_exit_code != 0 # Only execute if check failed uses: peter-evans/create-issue-from-file@v4.0.0 - with: title: Link Checker Report content-filepath: ./lychee/out.md From 740e79b9c2734151b3f64e684f7b1899068caad4 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:19:23 +0100 Subject: [PATCH 07/26] Create .lycheeignore --- .lycheeignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .lycheeignore diff --git a/.lycheeignore b/.lycheeignore new file mode 100644 index 00000000..e8ff0db3 --- /dev/null +++ b/.lycheeignore @@ -0,0 +1,2 @@ +mailman.cgd.ucar.edu +cfeditor.ceda.ac.uk From e0ab81d202e78ee0123873a23c5bc7cb1e31f50b Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:23:56 +0100 Subject: [PATCH 08/26] master --> main --- constitution.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/constitution.md b/constitution.md index 75ddb07c..73742afc 100644 --- a/constitution.md +++ b/constitution.md @@ -96,4 +96,4 @@ The standard names committee will make proposals for modification of conventions The membership of the standard names committee should include representatives of the various scientific user communities of the CF standard. -[code-of-conduct]: (https://github.com/cf-convention/cf-conventions/blob/master/CODE_OF_CONDUCT.md) +[code-of-conduct]: (https://github.com/cf-convention/cf-conventions/blob/main/CODE_OF_CONDUCT.md) From 06ac3d50b5ba9da82036564db04a2498acbe907f Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:29:22 +0100 Subject: [PATCH 09/26] Fix syntax --- constitution.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/constitution.md b/constitution.md index 73742afc..5030ad65 100644 --- a/constitution.md +++ b/constitution.md @@ -96,4 +96,4 @@ The standard names committee will make proposals for modification of conventions The membership of the standard names committee should include representatives of the various scientific user communities of the CF standard. -[code-of-conduct]: (https://github.com/cf-convention/cf-conventions/blob/main/CODE_OF_CONDUCT.md) +[code-of-conduct]: https://github.com/cf-convention/cf-conventions/blob/main/CODE_OF_CONDUCT.md "Code of Conduct" From 61b459254cb4927986f1ef6354900d2d59f52495 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:30:58 +0100 Subject: [PATCH 10/26] Include more addresses to exclude --- .lycheeignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.lycheeignore b/.lycheeignore index e8ff0db3..0ce7b275 100644 --- a/.lycheeignore +++ b/.lycheeignore @@ -1,2 +1,4 @@ mailman.cgd.ucar.edu cfeditor.ceda.ac.uk +http://wps-web1.ceda.ac.uk/submit/form?proc_id=CFChecker +http://kitt.llnl.gov/trac/wiki/SatelliteData From 7946266778b4380f94ec0e129a70b59ffc7f875b Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:34:58 +0100 Subject: [PATCH 11/26] Annotate ignored files --- .lycheeignore | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.lycheeignore b/.lycheeignore index 0ce7b275..eb96c09a 100644 --- a/.lycheeignore +++ b/.lycheeignore @@ -1,4 +1,4 @@ -mailman.cgd.ucar.edu -cfeditor.ceda.ac.uk -http://wps-web1.ceda.ac.uk/submit/form?proc_id=CFChecker -http://kitt.llnl.gov/trac/wiki/SatelliteData +mailman.cgd.ucar.edu # from faq.md. Server times out. +cfeditor.ceda.ac.uk # from discussion.md. Server times out. +wps-web1.ceda.ac.uk # from software.md +http://kitt.llnl.gov/trac/wiki/SatelliteData # from faq.md From 4448a8cdbe5cc58fb2e61689e3427c464d4ffc94 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:40:19 +0100 Subject: [PATCH 12/26] Describe exclusions --- .github/workflows/check_links.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 40e20cf6..5121ff29 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -22,6 +22,11 @@ jobs: - name: Check links id: lychee uses: lycheeverse/lychee-action@v1.0.4 + # See exclusions in .lycheeignore, commented here since that file accepts no comments: + # mailman.cgd.ucar.edu from faq.md. Server times out. + # cfeditor.ceda.ac.uk from discussion.md. Server times out. + # wps-web1.ceda.ac.uk software.md + # http://kitt.llnl.gov/trac/wiki/SatelliteData faq.md - name: Upload report if: ${{ always() }} From e0d04425566ed678f22930932420a6a466ff3db9 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:40:24 +0100 Subject: [PATCH 13/26] Correct syntax in ignorefile --- .lycheeignore | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.lycheeignore b/.lycheeignore index eb96c09a..ea803631 100644 --- a/.lycheeignore +++ b/.lycheeignore @@ -1,4 +1,4 @@ -mailman.cgd.ucar.edu # from faq.md. Server times out. -cfeditor.ceda.ac.uk # from discussion.md. Server times out. -wps-web1.ceda.ac.uk # from software.md -http://kitt.llnl.gov/trac/wiki/SatelliteData # from faq.md +mailman.cgd.ucar.edu +cfeditor.ceda.ac.uk +wps-web1.ceda.ac.uk +http://kitt.llnl.gov/trac/wiki/SatelliteData From cac210b6a1810b515cf3e47b856abddc4f96084a Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:46:57 +0100 Subject: [PATCH 14/26] Upgrade lychee version to create issue iff fail --- .github/workflows/check_links.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 5121ff29..77f342d4 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -21,7 +21,9 @@ jobs: - name: Check links id: lychee - uses: lycheeverse/lychee-action@v1.0.4 + uses: lycheeverse/lychee-action@v1.5.4 + env: + GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} # See exclusions in .lycheeignore, commented here since that file accepts no comments: # mailman.cgd.ucar.edu from faq.md. Server times out. # cfeditor.ceda.ac.uk from discussion.md. Server times out. @@ -37,7 +39,7 @@ jobs: # fail: true # fail job if no go - name: Create Issue From File - #if: env.lychee_exit_code != 0 # Only execute if check failed + if: env.lychee_exit_code != 0 # Only execute if check failed uses: peter-evans/create-issue-from-file@v4.0.0 with: title: Link Checker Report From a23c042b1349372f0122ee73f1571c960009ba46 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:53:31 +0100 Subject: [PATCH 15/26] Revert version --- .github/workflows/check_links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 77f342d4..0d4eb3bb 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -21,7 +21,7 @@ jobs: - name: Check links id: lychee - uses: lycheeverse/lychee-action@v1.5.4 + uses: lycheeverse/lychee-action@v1.0.4 env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} # See exclusions in .lycheeignore, commented here since that file accepts no comments: From 9f8f7298a14bcdbbffdaa6def66e137716ec4941 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:55:05 +0100 Subject: [PATCH 16/26] Use latest v1 --- .github/workflows/check_links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 0d4eb3bb..1cbb64d8 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -21,7 +21,7 @@ jobs: - name: Check links id: lychee - uses: lycheeverse/lychee-action@v1.0.4 + uses: lycheeverse/lychee-action@v1 env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} # See exclusions in .lycheeignore, commented here since that file accepts no comments: From 9200ba37ef6fce1dc9a7a12079a04a4f53577317 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 14:58:09 +0100 Subject: [PATCH 17/26] Revert to 1.0.4, upload report only on fail Latest fails due to bad characters in one of the files. --- .github/workflows/check_links.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 1cbb64d8..f975b3b1 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -21,7 +21,7 @@ jobs: - name: Check links id: lychee - uses: lycheeverse/lychee-action@v1 + uses: lycheeverse/lychee-action@v1.0.4 env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} # See exclusions in .lycheeignore, commented here since that file accepts no comments: @@ -31,7 +31,7 @@ jobs: # http://kitt.llnl.gov/trac/wiki/SatelliteData faq.md - name: Upload report - if: ${{ always() }} + if: env.lychee_exit_code != 0 uses: actions/upload-artifact@v1 with: name: Link check report From c15cd9156a4c9bb045c8f4e4e50af9a66cfbc8ab Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 15:06:07 +0100 Subject: [PATCH 18/26] Get rid of doubled docs --- .github/workflows/check_links.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index f975b3b1..016244a7 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -19,16 +19,12 @@ jobs: - name: Checkout uses: actions/checkout@v2 + # See exclusions in .lycheeignore, remove lines and give it a whirl if you're hunting broken links - name: Check links id: lychee uses: lycheeverse/lychee-action@v1.0.4 env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - # See exclusions in .lycheeignore, commented here since that file accepts no comments: - # mailman.cgd.ucar.edu from faq.md. Server times out. - # cfeditor.ceda.ac.uk from discussion.md. Server times out. - # wps-web1.ceda.ac.uk software.md - # http://kitt.llnl.gov/trac/wiki/SatelliteData faq.md - name: Upload report if: env.lychee_exit_code != 0 From 5bdc854c530f472522bd5360ee931078ae3c6cdd Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 15:08:37 +0100 Subject: [PATCH 19/26] Test if removing a regex causes stuff to fail It should! If so, happily revert and remove WIP tag --- .lycheeignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.lycheeignore b/.lycheeignore index ea803631..1bc8e830 100644 --- a/.lycheeignore +++ b/.lycheeignore @@ -1,4 +1,3 @@ -mailman.cgd.ucar.edu cfeditor.ceda.ac.uk wps-web1.ceda.ac.uk http://kitt.llnl.gov/trac/wiki/SatelliteData From 0410e8abc9cf64b297ff8893de205da16a9d027b Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 15:12:04 +0100 Subject: [PATCH 20/26] Fiddle with env --- .github/workflows/check_links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 016244a7..f3533896 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -27,7 +27,7 @@ jobs: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - name: Upload report - if: env.lychee_exit_code != 0 + if: env.exit_code != 0 uses: actions/upload-artifact@v1 with: name: Link check report From 5926853cd978f278d129b157bca0ff263244e2cf Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Fri, 6 Jan 2023 15:14:36 +0100 Subject: [PATCH 21/26] Fail on bad links --- .github/workflows/check_links.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index f3533896..3865ff28 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -23,6 +23,8 @@ jobs: - name: Check links id: lychee uses: lycheeverse/lychee-action@v1.0.4 + with: + fail: true env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} From a02e4e702189182cc31bf565c1358a91d89ac3e6 Mon Sep 17 00:00:00 2001 From: Sadie Louise Bartholomew Date: Fri, 13 Jan 2023 17:10:56 +0000 Subject: [PATCH 22/26] Update lycee-action version for link-checking workflow --- .github/workflows/check_links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 3865ff28..bbca98f7 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -22,7 +22,7 @@ jobs: # See exclusions in .lycheeignore, remove lines and give it a whirl if you're hunting broken links - name: Check links id: lychee - uses: lycheeverse/lychee-action@v1.0.4 + uses: lycheeverse/lychee-action@v1.5.4 with: fail: true env: From 7a5dacea9922a7159fddf7d1fe9e751a420b8255 Mon Sep 17 00:00:00 2001 From: Sadie Louise Bartholomew Date: Fri, 13 Jan 2023 17:14:56 +0000 Subject: [PATCH 23/26] Ensure failure of link-checking workflow job w/ any bad links --- .github/workflows/check_links.yml | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index bbca98f7..a419dc39 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -17,25 +17,38 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 - # See exclusions in .lycheeignore, remove lines and give it a whirl if you're hunting broken links + # See exclusions in .lycheeignore, remove lines and give it a + # whirl if you're hunting broken links - name: Check links id: lychee - uses: lycheeverse/lychee-action@v1.5.4 + uses: lycheeverse/lychee-action@master with: fail: true + # We need to exclude the cf-conventions-1.2 and .3 build dirs + # because they lead to an error of: + # Error: Cannot read input content from file + # Caused by: + # stream did not contain valid UTF-8 + # Note: --exclude-path only takes one input path, so we need + # to set it twice. + # Note also we define a .lycheeignore file to exclude some + # specific links for checking, instead of using --exclude. + args: > + --no-progress './**/*.md' './**/*.html' + --exclude-path Data/cf-conventions/cf-conventions-1.2/build/ + --exclude-path Data/cf-conventions/cf-conventions-1.3/build/ env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - + - name: Upload report if: env.exit_code != 0 uses: actions/upload-artifact@v1 with: name: Link check report path: ./lychee/out.md - # fail: true # fail job if no go - + - name: Create Issue From File if: env.lychee_exit_code != 0 # Only execute if check failed uses: peter-evans/create-issue-from-file@v4.0.0 From e37d569dd638c08c91487bbe06df2bbf72619a4d Mon Sep 17 00:00:00 2001 From: Sadie Louise Bartholomew Date: Fri, 20 Jan 2023 17:46:33 +0000 Subject: [PATCH 24/26] Only check markdown in link-checking workflow --- .github/workflows/check_links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index a419dc39..0228dd8b 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -36,7 +36,7 @@ jobs: # Note also we define a .lycheeignore file to exclude some # specific links for checking, instead of using --exclude. args: > - --no-progress './**/*.md' './**/*.html' + --no-progress './**/*.md' --exclude-path Data/cf-conventions/cf-conventions-1.2/build/ --exclude-path Data/cf-conventions/cf-conventions-1.3/build/ env: From 9198b484306307f7f9270fc00f793925823fc460 Mon Sep 17 00:00:00 2001 From: Sadie Louise Bartholomew Date: Fri, 20 Jan 2023 17:51:18 +0000 Subject: [PATCH 25/26] Only check markdown of immediate dir. in link-checking workflow --- .github/workflows/check_links.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index 0228dd8b..aa047360 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -36,7 +36,7 @@ jobs: # Note also we define a .lycheeignore file to exclude some # specific links for checking, instead of using --exclude. args: > - --no-progress './**/*.md' + --no-progress './*.md' --exclude-path Data/cf-conventions/cf-conventions-1.2/build/ --exclude-path Data/cf-conventions/cf-conventions-1.3/build/ env: From 695d26bc936b2f2c66b3a0399c50e7c71e1fd493 Mon Sep 17 00:00:00 2001 From: Sadie Louise Bartholomew Date: Fri, 20 Jan 2023 17:53:23 +0000 Subject: [PATCH 26/26] Remove HTML exclusions now unnecessary in link-checking workflow --- .github/workflows/check_links.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/check_links.yml b/.github/workflows/check_links.yml index aa047360..738e4924 100644 --- a/.github/workflows/check_links.yml +++ b/.github/workflows/check_links.yml @@ -37,8 +37,6 @@ jobs: # specific links for checking, instead of using --exclude. args: > --no-progress './*.md' - --exclude-path Data/cf-conventions/cf-conventions-1.2/build/ - --exclude-path Data/cf-conventions/cf-conventions-1.3/build/ env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}