From 0a8c09f58f7648b5b2caec3710cb37ff69297ff2 Mon Sep 17 00:00:00 2001 From: Saad <38024451+sdadn@users.noreply.github.com> Date: Wed, 31 Jan 2024 14:08:39 -0600 Subject: [PATCH 1/3] upgraded to package-jsons-lint v2 --- packages/package-json-lint-config-terra/CHANGELOG.md | 3 +++ packages/package-json-lint-config-terra/package.json | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/package-json-lint-config-terra/CHANGELOG.md b/packages/package-json-lint-config-terra/CHANGELOG.md index e404d6cac..e6581f1f9 100644 --- a/packages/package-json-lint-config-terra/CHANGELOG.md +++ b/packages/package-json-lint-config-terra/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Breaking Changes + * `package-json-lint` peer dependency has been upgraded to v2. + ## 1.7.0 - (August 31, 2023) * Changed diff --git a/packages/package-json-lint-config-terra/package.json b/packages/package-json-lint-config-terra/package.json index d247e2dca..4b3cfb613 100644 --- a/packages/package-json-lint-config-terra/package.json +++ b/packages/package-json-lint-config-terra/package.json @@ -40,9 +40,8 @@ }, "devDependencies": { "@cerner/eslint-config-terra": "^5.6.0", - "eslint": "^7.32.0" }, "peerDependencies": { - "@cerner/package-json-lint": "^1.0.0" + "@cerner/package-json-lint": "2" } } From f8126c01d29ba060e185aeb02cdb1af6d215f9c1 Mon Sep 17 00:00:00 2001 From: Saad Adnan <38024451+sdadn@users.noreply.github.com> Date: Wed, 31 Jan 2024 14:49:23 -0600 Subject: [PATCH 2/3] fixed dangling comma in package.json --- packages/package-json-lint-config-terra/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/package-json-lint-config-terra/package.json b/packages/package-json-lint-config-terra/package.json index 4b3cfb613..fd01827b6 100644 --- a/packages/package-json-lint-config-terra/package.json +++ b/packages/package-json-lint-config-terra/package.json @@ -39,7 +39,7 @@ "lint:js:fix": "eslint --ext .js,.jsx . --fix" }, "devDependencies": { - "@cerner/eslint-config-terra": "^5.6.0", + "@cerner/eslint-config-terra": "^5.6.0" }, "peerDependencies": { "@cerner/package-json-lint": "2" From 447997343d09f6366a1eae64f3ce8125e5f680b8 Mon Sep 17 00:00:00 2001 From: Saad <38024451+sdadn@users.noreply.github.com> Date: Wed, 31 Jan 2024 16:12:57 -0600 Subject: [PATCH 3/3] Added upgrade guide --- packages/terra-toolkit-docs/CHANGELOG.md | 7 +++++-- .../tool/package-json-lint/About.1.tool.mdx | 10 +++++++++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/packages/terra-toolkit-docs/CHANGELOG.md b/packages/terra-toolkit-docs/CHANGELOG.md index 2da7edfc4..5b10308d0 100644 --- a/packages/terra-toolkit-docs/CHANGELOG.md +++ b/packages/terra-toolkit-docs/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Changed + * Added upgrade guide for `package-json-lint-config-terra@2`. + ## 2.26.0 - (December 11, 2023) * Changed @@ -15,12 +18,12 @@ ## 2.24.0 - (October 26, 2023) * Changed - * Updated upgrade guide for `stylelint-config-terra`. + * Updated upgrade guide for `stylelint-config-terra@5`. ## 2.23.0 - (September 26, 2023) * Added - * Added upgrade guide for `jest-config-terra@2.0.0`. + * Added upgrade guide for `jest-config-terra@2`. ## 2.22.0 - (August 31, 2023) diff --git a/packages/terra-toolkit-docs/src/terra-dev-site/tool/package-json-lint/About.1.tool.mdx b/packages/terra-toolkit-docs/src/terra-dev-site/tool/package-json-lint/About.1.tool.mdx index 7014dfc6a..9d6658b4e 100644 --- a/packages/terra-toolkit-docs/src/terra-dev-site/tool/package-json-lint/About.1.tool.mdx +++ b/packages/terra-toolkit-docs/src/terra-dev-site/tool/package-json-lint/About.1.tool.mdx @@ -31,10 +31,18 @@ npm install @cerner/package-json-lint-config-terra --save-dev "lint:package-json": "npm run terra -- package-json-lint", ``` -## Upgrade Guide +## Upgrade Guide for package-json-lint ### Upgrading to version 2 Package JSON Lint v2 mainly removes rules for IE10 support since it is no longer supported. If you have IE10 based dependencies in your project, please upgrade or remove them. Otherwise, no additional action is needed to upgrade to v2. + + +## Upgrade Guide for package-json-lint-config-terra + +### Upgrading to version 2 + +`package-json-lint-config-terra@2` now requires `package-json-lint@2` as a peer dependency. +Make sure the correct version is used to prevent any peer dependency conflicts.