-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: add grid gap property for more flexibility #1106
Comments
Hi @RavinaSamaroo let's chat about this next week when you are back :) |
Consider the new spacing component on the Figma side. |
Needs decision documented and to be considered together with spacing component. |
Initial discussion with proposed next steps was there with @melaniebmn and @realdylanzheng , has to be documented here before going back into product backlog |
Proposed solution:
Note: old proposed range of spacing values: |
Could be added into the Sprint backlog but needs better refinement first on def of done @daine |
Update: Adjustment to the spacing range after our typography updates. The new range will include the values |
The new gap properties have been added in this PR. |
Problem
On certain viewports, the spacing for the grid gap is too much. Need to override with css (see below). We need to allow changing the spacing values between containers on the grid component.
Site.css:
Acceptance criteria
<gap>
properties that allow users to change the value of the gap depending on the viewport and adhere to the vertical rhythm of the new typography.<gcds-soacing-150>
to<gcds-spacing-800>
.<gcds-spacing-300>
.Definition of done
The new
gap
,gapTablet
, andgapDesktop
properties have been added and provide the values<gcds-soacing-150>
to<gcds-spacing-800>
as options.The text was updated successfully, but these errors were encountered: