Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signer allows reimporting the same Ed25119 key multiple time #79

Open
cspramit opened this issue Jun 2, 2021 · 3 comments
Open

Signer allows reimporting the same Ed25119 key multiple time #79

cspramit opened this issue Jun 2, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cspramit
Copy link

cspramit commented Jun 2, 2021

Issue: Signer correctly detects and disallows importing the same Secp256k1 key again but it fails to do so with Ed25119 keys.

Using the signer plugin import the same Ed25119 secret key file twice
Result: it passes the check and allows the upload

@cspramit cspramit added the bug Something isn't working label Jun 2, 2021
@piotr-dziubecki piotr-dziubecki added this to the 1.4.0 milestone Jun 28, 2021
@George-cl
Copy link
Contributor

@cspramit / @piotr-dziubecki I believe this is actually resolved with the latest #123 PR - feel free to test it again in case we can close this.

@cspramit
Copy link
Author

@George-cl this is not resolved and still an issue - we can share screen if needed, we can also hack this for Secp keys too if one is pem and other cer

@George-cl
Copy link
Contributor

Yeah I must have misremembered testing it - will resolve this in 1.4.0

@George-cl George-cl modified the milestones: 1.4.0, 1.5.0 Sep 9, 2021
@George-cl George-cl removed this from the Signer 1.5.0 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants