Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a ’Load’ lifecycle #1424

Open
swankjesse opened this issue Sep 3, 2024 · 0 comments
Open

We need a ’Load’ lifecycle #1424

swankjesse opened this issue Sep 3, 2024 · 0 comments
Labels

Comments

@swankjesse
Copy link
Collaborator

In our use of Zipline we’re doing fancy things:

  1. As soon as the ZiplineManifest is ready, we inspect the metadata for URLs and download them. These downloads occur in parallel with code downloads.
  2. When the rest of the code is ready we bind a ZiplineService that exposes these downloads to guest code.

Unfortunately the implementation of this is clumsy. We’re hooking into EventListener, using manifestReady() for 1 and ziplineCreated() for 2. This isn’t what EventListener is for!

I’d prefer a proper LoadAttempt class with support for a user-specified tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant