-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sources git URL not supporting tags #287
Comments
Great point, we should definitely support that! |
I can help with that. Can you point me to what needs to be changed?
… On Jun 7, 2022, at 8:23 PM, Alec Thomas ***@***.***> wrote:
Great point, we should definitely support that!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Oh nice, thank you. The code is currently living here, for downloading a package via git. I think this logic could be pulled out into a top-level |
Happy to jump into this and assist. We're wanting to use |
I'm not sure what atlas is, but this issue is specifically talking about using git tags for extra package manifest sources, not for packages themselves. If this is Atlas, you'd likely download the tarballs from their site. If you're talking about using tags for auto-versioning, a better option would be to use the html auto-versioning. This is also what we do for Go. |
@alecthomas thanks for the clarification! Taking up the need for an index page of releases with the Atlas team (it's this atlas for clarification). |
The bin/hermit.hcl sources variable is not supporting repo tags. Example:
sources = ["https://gitlab.com/onis-oss/hermit-packages.git#onis-oss"]
Results in this error:
fatal:hermit: /home/rolandknight/git/gitlab.com/onis-oss/tlc/sandbox/bin/hermit.hcl: unsupported source "https://gitlab.com/onis-oss/hermit-packages.git#onis-oss"
The text was updated successfully, but these errors were encountered: