Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run the sample as an instant app #110

Open
AlecKazakova opened this issue Jan 16, 2024 · 0 comments
Open

Cannot run the sample as an instant app #110

AlecKazakova opened this issue Jan 16, 2024 · 0 comments

Comments

@AlecKazakova
Copy link
Collaborator

Steps to reproduce:

  1. Add <dist:module dist:instant="true"/> to sample/app/main/AndroidManifest.xml
  2. Change the run configuration for the sample app to "Deploy as an Instant App" and run

This then gives a configuration error for each dynamic feature module:

1: Task failed with an exception.
-----------
* What went wrong:
A problem was found with the configuration of task ':bigboxfeature:processDebugAndroidTestResources' (type 'LinkApplicationAndroidResourcesTask').
  - In plugin 'com.android.internal.version-check' type 'com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask' property 'manifestFiles' doesn't have a configured value.
    
    Reason: This property isn't marked as optional and no value has been configured.
    
    Possible solutions:
      1. Assign a value to 'manifestFiles'.
      2. Mark property 'manifestFiles' as optional.
    
    For more information, please refer to https://docs.gradle.org/8.2/userguide/validation_problems.html#value_not_set in the Gradle documentation.

I'm not actually sure this is related to BDF yet, but I'm able to do a pretty standard instant app build which fails if I apply BDF and all its related thing (ie this might be like a KSP issue)

I attempted to resolve by manually setting the manifestFiles property for LinkApplicationAndroidResourcesTask here

I also tried monkeypatching that task to make the property optional but it had so many internal references I got like 20 files of copying deep and decided it was probably not a workable solution

Even if this isn't a BDF issue, would be nice to fix it with BDF if we can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant