Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user when unrecognized image meta is dropped. #160

Open
pivotaljohn opened this issue Sep 16, 2021 · 0 comments
Open

Warn the user when unrecognized image meta is dropped. #160

pivotaljohn opened this issue Sep 16, 2021 · 0 comments
Labels
enhancement This issue is a feature request priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@pivotaljohn
Copy link
Contributor

Describe the problem/challenge you have
When image meta is being parsed from an upstream imgpkg lock file,
if the structure of the meta is unknown to kbld (e.g. the meta was created by a newer version of kbld than the one being used to deploy),
then that meta is discarded without warning.

Describe the solution you'd like
While parsing meta, if one is unrecognized:

  • with normal output, give one general warning (e.g. "There was some resolution history that was unrecognized and therefore discarded. This had no effect on successfully resolving image references. Run again with --debug for details.")
  • if the user supplies the --debug flag (which doesn't exist at the time of writing), then report each unrecognized meta.

Anything else you would like to add:


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@pivotaljohn pivotaljohn added enhancement This issue is a feature request priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Sep 16, 2021
@pivotaljohn pivotaljohn changed the title Gently warn the user when image meta is dropped. Gently warn the user when unrecognized image meta is dropped. Sep 17, 2021
@pivotaljohn pivotaljohn changed the title Gently warn the user when unrecognized image meta is dropped. Warn the user when unrecognized image meta is dropped. Sep 17, 2021
@aaronshurley aaronshurley moved this to To Triage in Carvel Jul 25, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a feature request priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
Status: To Triage
Development

No branches or pull requests

1 participant