Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartographer 3d mapping in ROS2 #1515

Closed
JaehyunShim opened this issue Sep 14, 2020 · 8 comments
Closed

cartographer 3d mapping in ROS2 #1515

JaehyunShim opened this issue Sep 14, 2020 · 8 comments

Comments

@JaehyunShim
Copy link

Hi,

I wonder if this repository supports 3d mapping in ROS2. Since Dashing does not support XML format launch files, I think this has not been tested but just uploaded without testing. and It even looks just a copy-paste of the master branch.

Ryan

@MichaelGrupp
Copy link
Contributor

ROS2 is not officially supported by cartographer_ros yet, but there are plans to do so. We are unfortunately a bit slow with this at the moment as we are currently reviving this repository again as a community-based project. There is a pull request, but it is currently just a snapshot of a very outdated fork: #1488. The work that needs to be done is to apply similar changes to the current ROS1 master, or to integrate the changes that were made in ROS1 to the old ROS2 branch.

But if you want to accelerate this development of porting to ROS2, you're more than welcome to participate. Let me know if you have questions regarding that.

@Serafadam
Copy link

I have been using ros2 cartographer repository with some success

@JaehyunShim
Copy link
Author

@Serafadam @MichaelGrupp

Thank you. maybe I use the repository from the ros2 community. It looks well maintained and updated. I will close this issue.

@MichaelGrupp
Copy link
Contributor

Be aware that the ros2 repository is now 2.5 years behind upstream. But it should compile. As I said, this is the reason we and the OSRF want to make a new version here.

@JaehyunShim
Copy link
Author

@MichaelGrupp
Thank you for your comment. I will take a look at their repository and see what I can contribute here.

Jaehyun

@MichaelGrupp
Copy link
Contributor

Awesome, it would be great to get help for ROS2. If you have any questions let me know.

@Serafadam
Copy link

I think I'd also like to contribute to a newer port, but I have some questions regarding this first, should I create a new issue for that? @MichaelGrupp

@MichaelGrupp
Copy link
Contributor

@Serafadam Cool! You can comment here: #1536 I created a pinned issue so this doesn't get lost. We as maintainers will discuss some things this week and the whole thing is in a very early stage, but as I said I would be more than happy to involve people on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants