Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explanation on testing #15

Open
kukuruza opened this issue Mar 10, 2017 · 3 comments
Open

Better explanation on testing #15

kukuruza opened this issue Mar 10, 2017 · 3 comments

Comments

@kukuruza
Copy link

Hi, first of all, thanks for the great work! It was really easy to use.
I had a problem with refining my images with a pretrained model though.

In readme you say: "To refine all synthetic images with a pretrained model":

$ python main.py --is_train=False --synthetic_image_dir="./data/gaze/UnityEyes/"

You are missing the load_path argument. Apparently, it is path to the directory with models, and it is relative to logs dir. For example:

$ python main.py  --is_train=False --synthetic_image_dir="./data/gaze/UnityEyes/" --load_path generative_2017-03-07_01-40-07

There is no indication whatsoever, that the model is loaded rather than initialized during testing. And of course if it is initialized then it will simply write garbage to refined images, leaving you wondering.

I don't know though how to make it clear whether the model was loaded or initialized if you use tf.train.Supervisor, maybe specify wait_for_checkpoint=True when calling prepare_or_wait_for_session.

@carpedm20
Copy link
Owner

I see. Yes, I forgot to add load_path. In terms of initialization or loading, we can try something like https://github.com/openai/universe-starter-agent/blob/master/worker.py#L45. If you want you can give me an PR.

@luochuwei
Copy link

@kukuruza Have you solved the problem? Is the model loaded during testing ?

It seems that when we test our own images, the model wasn't loaded. And I could not get well refined images.

@kukuruza
Copy link
Author

@luochuwei, nothing beyond what I wrote in the first message. You need to add --load_path argument, where you specify the path to directory with your models relative to logs directory. E.g. --load_path generative_2017-03-07_01-40-07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants