Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-divider: Allow removal of specific dividers #4877

Open
petesfrench opened this issue Sep 26, 2023 · 7 comments
Open

p-divider: Allow removal of specific dividers #4877

petesfrench opened this issue Sep 26, 2023 · 7 comments
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@petesfrench
Copy link
Contributor

Pattern to amend

p-divider

Visual

Before:
image
After:
image

Code

.p-divider {
  .p-divider__block.no-divider {
    &::before {
      content: none;
    }
  }
}

Context

Design required a section of p-dividers without the initial divider, see figma. Could also be used to remove any other dividers

@jmuzina
Copy link
Member

jmuzina commented May 20, 2024

@petesfrench Hi, from what I can tell this was implemented as default behavior in this commit (this PR) in v4.11.0 and onward.

Can you check here and verify it's working as you need? Thanks!

@petesfrench
Copy link
Contributor Author

Thanks @jmuzina! I have (sort of) applied the change - unfortunately, I found another visual bug, so have had to change how we apply the p-divider class. Could you take a look for me please? canonical/ubuntu.com#13884

@bartaz
Copy link
Member

bartaz commented May 24, 2024

@petesfrench This component seems to be deprecated and not used in rebranded pages anymore, so from Vanilla point of view we don't want to put too much focus on this anymore.

Is this part of any new design? As far as I understand we should not be using those anymore.

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15240.

This message was autogenerated

@bartaz
Copy link
Member

bartaz commented Sep 24, 2024

Does it need addressing? Is this component meant to be used in new designs?

@lyubomir-popov
Copy link
Contributor

I'd rather deprecate this. We do not use it on rebranded pages, the whole rebranding is based on horizontal lines, not vertical

@bartaz
Copy link
Member

bartaz commented Sep 27, 2024

Triaged: let's deprecate the divider component. We don't plan to do any additional work on it.

@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 and removed P3 Needs decision Needs team agreement in terms of triaging. labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Development

No branches or pull requests

4 participants