-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p-divider: Allow removal of specific dividers #4877
Comments
@petesfrench Hi, from what I can tell this was implemented as default behavior in this commit (this PR) in v4.11.0 and onward. Can you check here and verify it's working as you need? Thanks! |
Thanks @jmuzina! I have (sort of) applied the change - unfortunately, I found another visual bug, so have had to change how we apply the |
@petesfrench This component seems to be deprecated and not used in rebranded pages anymore, so from Vanilla point of view we don't want to put too much focus on this anymore. Is this part of any new design? As far as I understand we should not be using those anymore. |
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15240.
|
Does it need addressing? Is this component meant to be used in new designs? |
I'd rather deprecate this. We do not use it on rebranded pages, the whole rebranding is based on horizontal lines, not vertical |
Triaged: let's deprecate the divider component. We don't plan to do any additional work on it. |
Pattern to amend
p-divider
Visual
Before:
After:
Code
Context
Design required a section of p-dividers without the initial divider, see figma. Could also be used to remove any other dividers
The text was updated successfully, but these errors were encountered: