From 56624c1daf91677ac7912e96ff8cc49ea4953486 Mon Sep 17 00:00:00 2001 From: "bors[bot]" <26634292+bors[bot]@users.noreply.github.com> Date: Thu, 12 Nov 2020 08:08:18 +0000 Subject: [PATCH] Merge #1809 1809: gbm-kms: Disable bypass by default. r=AlanGriffiths a=RAOF This triggers a GPU OOM (issue #1801) on the Pi3 when used with default settings. There may be due to us hanging on to buffers longer than they need to be, but it's not clear yet. Users who want the performance boost and are running on known hardware can set `--bypass=true`, but by default use the safe option of `false`. Co-authored-by: Christopher James Halse Rogers --- src/platforms/gbm-kms/server/kms/platform_symbols.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platforms/gbm-kms/server/kms/platform_symbols.cpp b/src/platforms/gbm-kms/server/kms/platform_symbols.cpp index dfa3570efcd..6eaeaa6c410 100644 --- a/src/platforms/gbm-kms/server/kms/platform_symbols.cpp +++ b/src/platforms/gbm-kms/server/kms/platform_symbols.cpp @@ -82,7 +82,7 @@ void add_graphics_platform_options(boost::program_options::options_description& mir::assert_entry_point_signature(&add_graphics_platform_options); config.add_options() (bypass_option_name, - boost::program_options::value()->default_value(true), + boost::program_options::value()->default_value(false), "[platform-specific] utilize the bypass optimization for fullscreen surfaces."); }