Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central style config file #73

Open
YashKumarVerma opened this issue Mar 10, 2021 · 3 comments
Open

Central style config file #73

YashKumarVerma opened this issue Mar 10, 2021 · 3 comments

Comments

@YashKumarVerma
Copy link
Contributor

YashKumarVerma commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
All modern IDE's come with auto-format features, and if they don't find a config file in the project, they use the default one. This can be problematic as some dev would share a 4 space tab and other would share a 2 spaced tab, spacing in functions, curly brackets, line length etc.

Describe the solution you'd like
A config file (.prettierrc ?), configured to the style guide being used in the project.
also a stricter linter that takes into account the common practices that can cause undefined behavior. The current configuration allows using var even when its known that it can create issues. Are there any particular reasons for lenient linting rules?

Describe alternatives you've considered

  • Adding pre-commit hooks to format the codebase when user commits can also be done in addition to the above.
  • A stricter linting ruleset (maybe derived from a well-known style like AirBNB)
  • A clear formatting guideline

Additional context

Willing to work on it after discussion from mods.

@YashKumarVerma
Copy link
Contributor Author

@birm ping 🔔

@birm
Copy link
Member

birm commented Mar 24, 2021

You can always submit a PR if you think a change is beneficial

@mks2002
Copy link

mks2002 commented Mar 3, 2023

Is this issue resolved ? I want to contribute on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants