Completed scheduled maintenance should appear in timeline #93 #117
+124
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrooksuk
requested changes
Oct 14, 2024
| @empty | ||
| <div class="text-zinc-500 dark:text-zinc-400 text-center"> | ||
| {{ __('No incidents reported between :from and :to.', ['from' => $from, 'to' => $to]) }} | ||
| @foreach ($incidents as $date => $incident) |
There was a problem hiding this comment.
Looking at this, I think that if incidents are empty, but schedules aren't, then nothing will show.
|
@steffjenl schedules have just had a refactor to now determine their status based on the |
* main: (61 commits) Use null safe op instead of optional helper Remove unused ProfileUpdateRequest form request Remove unused method Fix variable Add return type Fix bad resource relation Fix code styling Schedule status doesn't need to be defined manually Allow creating schedule updates from table view Add logout button to status page Don't add `autocomplete` to `TextColumn` Compile Assets Update DEPENDABOT.yml Use Node 22 when building assets Use PHP 8.3 when compiling assets Fix docblock Fix code styling Scheduled Maintenance Updates (cachethq#109) Fix ordering of incident timeline within a day Improve incident API ...
|
@steffjenl I've merged |
|
@steffjenl do you still have any appetite to get this merged or shall I look into it separately? I'd love for this to be your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbrooksuk can you look to this PR, Because Data Objects is not ready I have created an solution for the different types of objects for now.