Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canonicalize NaNs #20

Open
rvolosatovs opened this issue Apr 23, 2024 · 0 comments
Open

canonicalize NaNs #20

rvolosatovs opened this issue Apr 23, 2024 · 0 comments
Labels
enhancement New feature or request go wRPC Go support help wanted Extra attention is needed rust wRPC Rust support
Milestone
feature-completeness

Comments

@rvolosatovs
Copy link
Member

rvolosatovs commented Apr 23, 2024 •
edited
Loading

floating point number NaNs have exactly one canonical representation in component-model specification, which we should match to be compliant.

Basically this is about adapting https://github.com/WebAssembly/component-model/blob/c3ef2a99f7c70b8189a889314569c0ce38c0433b/design/mvp/canonical-abi/definitions.py#L415-L441 in float encoding (although I do think we can be more lenient of decoding side and accept any NaN)

Refs WebAssembly/component-model#336 (comment)
@rvolosatovs rvolosatovs added this to the feature-completeness milestone Apr 23, 2024
@rvolosatovs rvolosatovs added enhancement New feature or request good first issue Good for newcomers labels Apr 23, 2024
@rvolosatovs rvolosatovs added help wanted Extra attention is needed golang rust wRPC Rust support labels May 15, 2024
@rvolosatovs rvolosatovs moved this to Ready in wRPC 1.0.0 May 15, 2024
@rvolosatovs rvolosatovs added go wRPC Go support and removed golang labels May 29, 2024
@rvolosatovs rvolosatovs removed the good first issue Good for newcomers label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request go wRPC Go support help wanted Extra attention is needed rust wRPC Rust support
Projects
None yet
Milestone
feature-completeness
Development

No branches or pull requests
1 participant
@rvolosatovs