-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-standard type-hinting thoughout the library. #208
Comments
Are you referring to GUI hints in an IDE? I tried making this change but it doesn't make any difference in pycharm. Can you give me a way to test this? |
Yes, I am referring to IDE. It is weird that Pycharm makes no difference. I use VS-Code with official As can be seen in the image, becaues of non-standard type hinting, they fail to parse it and they think the type is You mentioned that it makes no diffrence, but you should get squiggly underline hiting from the editor saying you violated the types. At the moment, the |
Ah, I can see a similar prompt when hovering over the function name and it is more detailed when using |
My linters and type checkers are failing to provide any help due to non-standard way of type hinting used in the library,
For instance, in the file:
unified_trading
:The proper way of enshrining the logic that
symbol
can be eitherstr
ORlist[str]
is:Once fixed, type checker will be able to statically check all the code (including the library itself) for any inconsistency.
Can you guys please use the standards?
Thank you,
The text was updated successfully, but these errors were encountered: