Properly set infoLog length #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwasty
reviewed
Feb 25, 2020
| @@ -66,7 +66,7 @@ pub fn main_1_2_1() { | |||
|
|
|||
| // check for shader compile errors | |||
| let mut success = gl::FALSE as GLint; | |||
| let mut infoLog = Vec::with_capacity(512); | |||
| let mut infoLog = vec![0; 512]; | |||
| infoLog.set_len(512 - 1); // subtract 1 to skip the trailing null character | |||
There was a problem hiding this comment.
I guess this line is made obsolete by the change?
There was a problem hiding this comment.
Removing this line would include the null terminator which works just as fine (Edit: In most cases the string is going to be much less than 512 characters so there will almost always be many trailing null terminators. So yes this line is basically unnecessary). Your comment got me thinking though, I modified the PR to set the length the proper way by sending a mutable pointer to gl::GetShaderInfoLog to obtain the length of the string data copied to the infoLog buffer.
bwasty
reviewed
Feb 25, 2020
bwasty
reviewed
Feb 25, 2020
|
How's it look? @bwasty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gl::GetShaderInfoLogwill fill the first half of theinfoLogbuffer with valid utf8 data, but the second half of the buffer could be anything. This leads tostr::from_utf8(&infoLog).unwrap()sometimes working and sometimes panicking depending on what is in that region of memory wheninfoLogis allocated.Can close #16 when this is merged.