chore: fixed rounded prop and added tests to datepicker #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCerki
reviewed
Oct 26, 2022
Comment on lines
44
to
48
| rounded: { | ||
| input: ` | ||
| border-radius: 0.25em; | ||
| `, | ||
| }, |
There was a problem hiding this comment.
Can we add this to the global style object instead of the DatePicker component specifically? Or will that break other components' styles?
| import '@testing-library/jest-dom/extend-expect'; | ||
| import 'regenerator-runtime/runtime'; | ||
| import { changeSelectorToObject } from '../../bcgov-theme/utils/test-helpers'; |
There was a problem hiding this comment.
Might be good to move the test-helpers somewhere more general if we're going to be using them in multiple packages, but that can be future tech debt consideration
|
Forgot to mention earlier, if you put the issue number in the PR description after "Fixes #", then the issue will automatically close and update the board when the PR is merged |
BallardRobinett
force-pushed
the
562-fix-rounded-prop-in-datepicker
branch
from
c9129b0 to
54c7652
Compare
BCerki
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562
Proposed Changes