-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guarantee data coherence for key DAOs treasuries #77
Comments
Great. Added to the Product Backlog. |
Problem faced: in a lot of cases, tokens are missing in the Balances series because of the lone-transaction filter. |
Problem faced 2: token transfer histories are starting with negative values (negative delta in the first transfer listed in the Covalent transfers_v2 api, see https://www.covalenthq.com/docs/api/#/0/Get%20ERC20%20token%20transfers%20for%20address/USD/1 ). cc @acemasterjb |
First part of the fix ready to merge in #82 |
Historical transfers were not all properly taken into account, fixed in #87 Now, we still have (at least) the following issues with the PrimeDAO wallet:
For the USD balance discrepancy, I'm not sure for now what is the reason. It seems probable that the D2D token had a very volatile price and thus different data sources didn't record the same past values (day high? close? etc.) and which data source / method should be considered best.
|
Dumping this here, let's update with problems and solutions.
The text was updated successfully, but these errors were encountered: