Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support, Django 1.8 ~ 1.10 #12

Closed
wants to merge 9 commits into from

Conversation

fgmacedo
Copy link

This PR adds support for Python 3 (fixes #6) and Django from 1.8 to 1.10.

Improves the test coverage to 86%. WIth tox to automated tests with all supported versions.

It depends on the related PR to django-report-utils (burke-software/django-report-utils#27).

Please let me know if you need something else. I'm deploying a project using django-admin-export, so I can help to keep it up to date.

Best regards,

PS: Since it includes the changes from #10 and #11, i'm closing those PRs.

@fgmacedo fgmacedo changed the title Python3 support Python support, Django 1.8 ~1.10 Sep 21, 2016
@fgmacedo fgmacedo changed the title Python support, Django 1.8 ~1.10 Python support, Django 1.8 ~ 1.10 Sep 21, 2016
@fgmacedo fgmacedo changed the title Python support, Django 1.8 ~ 1.10 Python 3 support, Django 1.8 ~ 1.10 Sep 21, 2016
@bufke
Copy link
Member

bufke commented Sep 21, 2016

Would you be interested in maintaining this project? I no longer use it.

@fgmacedo
Copy link
Author

Yeah, no problem. Since I'm using it, I can keep it up to date. So let me know how to proceed.

@bufke
Copy link
Member

bufke commented Sep 21, 2016

You are welcome to use this repo if you want, I can give you access. Or forking is fine too. Let me know.

@fgmacedo
Copy link
Author

David, what about the django-report-utils, do you will keep It? Since It is a direct dependence, I'll need a new release including the changes on the PR that I sent to you.

I think that a fork or a new organization are the best options.

@fgmacedo
Copy link
Author

There's another option, that is the repository transfer, so github will redirect the URLs to the new repo, including forks, issues, etc.. https://help.github.com/articles/about-repository-transfers/

Let me know.

@bufke
Copy link
Member

bufke commented Jan 2, 2017

Sorry I forgot about all this. django-report-utils exists because it shared code between this and django-report-builder. But since then I've dropped working on this project and moved all the functionality I needed into report builder itself. The short answer is no I don't use it at all.

Let me know if you need anything from me like transferring the repo. You are welcome to fork, keep the namespace as is, or transfer it.

@fgmacedo
Copy link
Author

fgmacedo commented Jan 2, 2017

Hi, David! How are you? Happy new year!

I did a fork for my use since I need It working on Python 3.5. I've also joined all required code into a single project, under this repo: https://github.com/fgmacedo/django-export-action

The new project is released on PyPI as django-export-action.

Please let me know if you are ok with this.

Best regards!

@fgmacedo fgmacedo closed this Jan 2, 2017
@bufke
Copy link
Member

bufke commented Jan 3, 2017

Sounds good - I'll put a note on the readme here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3 Support
2 participants