Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal acceptance tests for exporter #692

Closed
natalieparellano opened this issue Aug 18, 2021 · 2 comments · Fixed by #698
Closed

Minimal acceptance tests for exporter #692

natalieparellano opened this issue Aug 18, 2021 · 2 comments · Fixed by #698

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Aug 18, 2021

Description

We have #467 for adding acceptance tests for the exporter. That issue intends for the tests for be comprehensive, which is a tall order. We should have very minimal acceptance tests for exporter that cover basic things, like:

  • it works
  • the output app image has the correct os / arch
  • the output cache image has the correct os / arch

Proposed solution

We could copy / paste some setup from the existing restorer acceptance tests (e.g., related to the cache). We should assume that it's a very simple build and maybe it's the first build so we don't have to re-use layers.

Additional context

This will help #435

@natalieparellano natalieparellano added this to the lifecycle-0.12.0 milestone Aug 18, 2021
@natalieparellano
Copy link
Member Author

Manually confirmed:

  • When provided an arm64 image as its working image, the exporter on arm64 will output an arm64 image
  • When creating a new cache image, the exporter on arm64 will create an image with empty arch; this image is pullable on an arm64 machine

Unknown:

  • What happens when the run image provided is a manifest list?
  • What happens when the cache image provided is a manifest list?

@natalieparellano
Copy link
Member Author

Messy branch with minimal tests needed to release arm: https://github.com/buildpacks/lifecycle/compare/exporter-acceptance?expand=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant