Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module resolution issue when importing action constants #212

Open
BBlackwo opened this issue Jan 24, 2022 · 0 comments
Open

Fix module resolution issue when importing action constants #212

BBlackwo opened this issue Jan 24, 2022 · 0 comments
Labels
build Related to the build/CI help wanted

Comments

@BBlackwo
Copy link
Collaborator

During the Angular 13 upgrade the build broke when doing an import from @ngrx/store:

import {
    INIT as INIT_ACTION,
    UPDATE as UPDATE_ACTION
} from '@ngrx/store';

The issue has to do with conflicting module resolution (CommonJS Modules vs ES Modules) see #208 (comment) for more info.

As a temporary workaround we have removed the import and hardcoded the action constants in d720252.

This issue is to put back the import and fix the module resolution. Some ideas:

  • Configure Jasmine to support ESM
  • Upgrade to the latest Jasmine
  • Move to a different testing library such as Jest
@BBlackwo BBlackwo added help wanted build Related to the build/CI labels Jan 24, 2022
@BBlackwo BBlackwo mentioned this issue Jan 24, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to the build/CI help wanted
Projects
None yet
Development

No branches or pull requests

1 participant