-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ascii art output optional? #91
Comments
Why I should be it like an option? |
Hi, i was referring to be able to configure whether to print it or not. It is a cool ascii, still when committing frequently I found it too much, for my personal taste the message would be enough. but of course, it is only about personal taste ;) don't want to be a joy killer :) |
Hi there, shall we close this issue as "wont fix" ? |
Hey, I agree the Ascii art should be optional! :) |
Don't worry. I will do cooming soon. |
@bruli Hello) are you going to review this pr #129 ? to be honest, I don't like the way I solved this issue. Maybe it will be better to make message printer as a component, make static method non static and add configuration to this component. I think it's bad idea to pass 'enableFaces' param everywhere, but that's the simplest decision i've found... What do you think? |
Can we get an answer to this? I really wish the faces were optional. |
this library is abandoned. don't use it. use phpcs, php-cs-fixer, static analyzers directly. |
Hi,
thanks in advance for this project
The text was updated successfully, but these errors were encountered: