Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ascii art output optional? #91

Open
davidmpaz opened this issue Mar 12, 2017 · 8 comments · May be fixed by #129
Open

Make ascii art output optional? #91

davidmpaz opened this issue Mar 12, 2017 · 8 comments · May be fixed by #129

Comments

@davidmpaz
Copy link

Hi,

thanks in advance for this project

@bruli
Copy link
Owner

bruli commented Mar 13, 2017

Why I should be it like an option?

@davidmpaz
Copy link
Author

Hi,

i was referring to be able to configure whether to print it or not. It is a cool ascii, still when committing frequently I found it too much, for my personal taste the message would be enough.

but of course, it is only about personal taste ;) don't want to be a joy killer :)

@davidmpaz
Copy link
Author

Hi there,

shall we close this issue as "wont fix" ?

@itaelle
Copy link

itaelle commented Jun 7, 2017

Hey, I agree the Ascii art should be optional! :)

@bruli
Copy link
Owner

bruli commented Jun 10, 2017

Don't worry. I will do cooming soon.

@alexgivi
Copy link

alexgivi commented Aug 1, 2019

Don't worry. I will do cooming soon.

@bruli Hello) are you going to review this pr #129 ? to be honest, I don't like the way I solved this issue. Maybe it will be better to make message printer as a component, make static method non static and add configuration to this component. I think it's bad idea to pass 'enableFaces' param everywhere, but that's the simplest decision i've found... What do you think?

@s2925534
Copy link

Can we get an answer to this? I really wish the faces were optional.

@alexgivi
Copy link

this library is abandoned. don't use it. use phpcs, php-cs-fixer, static analyzers directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants