Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Resource API following #778 #851

Closed
jclusso opened this issue Feb 24, 2024 · 1 comment
Closed

Issue with Resource API following #778 #851

jclusso opened this issue Feb 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jclusso
Copy link
Contributor

jclusso commented Feb 24, 2024

Calling add_resource in a site builder results in the following error since #778 was merged.

bridgetown-core/lib/bridgetown-core/front_matter/ruby.rb:12:in `initialize': wrong number of arguments (given 1, expected 0) (ArgumentError)

To Reproduce

Create a builder like below.

class Builders::MyBuilder < SiteBuilder

  def build
    add_resource(:page, "page.html") do
      title "title"
    end
  end

end

@michaelherold do you have an ideas? I'm currently looking into what might be the reason.

@jclusso jclusso added the bug Something isn't working label Feb 24, 2024
@jclusso
Copy link
Contributor Author

jclusso commented Feb 24, 2024

Nevermind. This ended up being some wierd issue from bundling my own fork locally and after running bundle update bridgetown instead of bundle update bridgetown-core a bunch of stuff got updated and this issue went away.

❯ bundle update bridgetown
Fetching https://github.com/jclusso/bridgetown.git
Fetching gem metadata from https://rubygems.org/..........
Resolving dependencies...
Using rack 2.2.8.1 (was 2.2.8)
Using faraday-net_http 3.1.0 (was 3.0.2)
Using public_suffix 5.0.4 (was 5.0.3)
Using faraday 2.9.0 (was 2.7.10)
Using addressable 2.8.6 (was 2.8.4)
Using tilt 2.3.0 (was 2.2.0)
Using ffi 1.16.3 (was 1.15.5)
Using roda 3.77.0 (was 3.70.0)
Bundle updated!

@jclusso jclusso closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant