-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Phlex template support via bundled configuration #729
Comments
I think Phlex is great, but I'd be reluctant to include it in core. It's still a new-ish project (relatively speaking) and I see it's usage very much as a personal preference thing. I doubt I'd reach for it in Bridgetown too often. I definitely think we should offer first-party support for it, but I'm in favour of a first-party plugin rather than including it in core. I just don't want core to expand too big and try to do too much. |
@ayushn21 Ah, the voice of reason! I was originally thinking of it being a separate plugin… my only question though is how to get the new site template working, if someone wants to start using Phlex. Maybe the |
Yup I think a bundle configuration is the way to go! .... we could absolutely give it some "special treatment" in the CLI rather than going through the usual |
I'm not really working with Phlex these days, and we have a replacement of sorts for this in the form of string-based procs (see #817, so just going to close the issue. |
Update: see #729 (comment) (we'll keep the main support out of core but still offer the CLI option)
Phlex is a really awesome new "Ruby DSL" template format which lets you output HTML and other markup right from pure Ruby code.
I've been finding it helpful enough on various projects that I think we should offer first-party support for it in Bridgetown, and since the Lifeform gem also uses Phlex and I expect Lifeform to get used a lot on various sites in future once it's fully baked, it seems like a no-brainer.
I have some demo code already to use Phlex in components and even within a pure Ruby page template/layout, so I just need to extract that out into a PR that we can play around with here.
Needless to say, it should be a viable option for new site builds, aka
bridgetown new mysite -t phlex
(which would actually set the "default" template handler to ERB for things like Markdown but then offer Phlex components and view helpers)The text was updated successfully, but these errors were encountered: