Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUD-09 success message is trimmed when multiline #1316

Open
yanascz opened this issue Oct 26, 2024 · 1 comment
Open

LUD-09 success message is trimmed when multiline #1316

yanascz opened this issue Oct 26, 2024 · 1 comment

Comments

@yanascz
Copy link

yanascz commented Oct 26, 2024

Expected Behaviour

Multiline success messages shall be visible untrimmed in the app without the need to leave the app.

Other LN wallets use either of these solutions:

  1. Unmodified success message is shown. (preferred)
    • Some wallets wrap it in a scrollable view with a border.
  2. Line breaks are replaced with " ". (sufficient)
    • This one should be an easy fix. However, would be great for the copy button to copy the original message.

How To Reproduce?

  1. Scan an LNURL-pay QR code of a service that uses LUD-09 success message.
    You can use the one below.
  2. Confirm the payment and wait for the success dialog to appear.
    Notice there are only two lines present, the rest is trimmed.
  3. Close the dialog and open payment details, expand the Message field.
    Notice there are only four lines present, the rest is still trimmed.
  4. Use the copy button and paste the message somewhere else.
    Notice there are actually eight lines in the message.

Screenshots

Screenshot 2024-10-26 at 18 52 16
Screenshot 2024-10-26 at 18 53 01
Screenshot 2024-10-26 at 19 16 21

QR Code for Testing

QR code

Operating System

iOS 18.0.1

Breez Version

1.1.19 from App Store

@yanascz
Copy link
Author

yanascz commented Oct 27, 2024

Looking at lnurl_success_action_dialog.dart, what is the motivation to limit message success action to 2 lines? 🤔 The URL success action has 4 lines configured. And if there’s an error, 10+ lines is not an issue:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant