Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package manager import not working #17

Open
triple7 opened this issue Jan 1, 2023 · 5 comments
Open

Package manager import not working #17

triple7 opened this issue Jan 1, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@triple7
Copy link

triple7 commented Jan 1, 2023

Hi,

First off thanks for this great module, it will really help me take a lot of server code out and put it into my app's client side functionality.

I've just finished a Swift wrapper for the MAST API https://github.com/triple7/SwiftMAST

I am at the point of testing product downloads and file manipulation using FITSCore.

Just followed the instructions but I get the 2 errors below:
SwiftMAST, 3 issues
dependency 'fitscore' is not used by any target
product 'FITS' required by package 'swiftmast' target 'SwiftMAST' not found.
FITS, Error
No such module 'FITS'

The relevant portions are:

            targets: ["SwiftMAST"]),
    ],
    dependencies: [
        .package(url: "https://github.com/brampf/fitscore", .upToNextMajor(from: "0.3.0")),    ],
    targets: [
        // Targets are the basic building blocks of a package. A target can define a module or a test suite.
        // Targets can depend on other targets in this package, and on products in packages this package depends on.
        .target(
            name: "SwiftMAST",
            dependencies: ["FITS"]),

Hopefully I can get an answer as I'm working starting Tuesday and would like to have this package completed before then haha

Happy new year :)

@brampf
Copy link
Owner

brampf commented Jan 1, 2023

Hi,

first of all: a happy new year to you, too :)

On the topic: it seems like something changed in the swift package manager since I wrote that documentation. Since the name of the package and the target differ, you need to explicitly name the package in the dependencies. Have a look over at FITSKit.
Apologies for not keeping the documentation up-to-date. But this project is still maintained. So in case you need something, please feel free to ask.

@triple7
Copy link
Author

triple7 commented Jan 1, 2023 via email

@triple7
Copy link
Author

triple7 commented Jan 1, 2023 via email

@triple7
Copy link
Author

triple7 commented Jan 1, 2023 via email

@brampf
Copy link
Owner

brampf commented Jan 1, 2023

Well, it seems like this lib needs update and probably could get rid of the numerics dependency at all like it does on linux. Feel free to create a pull request, I'm looking forward to review and merge

@brampf brampf added the documentation Improvements or additions to documentation label Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants