Relative path #425
Relative path #425
Conversation
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
| return comp; | ||
| if (has_scheme()) | ||
| { | ||
| comp = detail::ci_compare( |
There was a problem hiding this comment.
we need this as a public function in grammar if it is a case-insensitive comparison
|
quite a lot here ! |
Codecov Report
@@ Coverage Diff @@
## develop #425 +/- ##
===========================================
- Coverage 97.92% 97.84% -0.08%
===========================================
Files 132 132
Lines 6349 6494 +145
===========================================
+ Hits 6217 6354 +137
- Misses 132 140 +8
Continue to review full report at Codecov.
|
alandefreitas
force-pushed
the
relative_path
branch
from
7558275 to
76cb2ff
Compare
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
Yes. This function seems useful. The PR was also useful to find lots of small bugs and features missing here and there. Like some problems with the Some other questions that came up:
|
|
Oh... look what URI.js says about https://github.com/medialize/URI.js/blob/28976cde5bb32a433ab78c4a32ef58f39d2cabf6/test/test.js#L1479 So we only need |
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
alandefreitas
force-pushed
the
relative_path
branch
2 times, most recently
from
8e3f0e4 to
9ad001f
Compare
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
alandefreitas
force-pushed
the
relative_path
branch
from
9ad001f to
4a6dd2d
Compare
|
I fixed the last test that was failing: check("/../path/x/../to/y/../somewhere/else", "/a/../../path/to/a", "../a");This function had a problem similar to As usual, I tried many solutions and realized comparing the segments in reverse is the only solution with linear cost. Because of how hard this is and so we can move on, I used the other solution which could be n^2 in a very edgy case. |
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
1 similar comment
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
alandefreitas
force-pushed
the
relative_path
branch
from
4a6dd2d to
11b4453
Compare
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
|
we can use temporary memory with |
alandefreitas
force-pushed
the
relative_path
branch
from
11b4453 to
32c33c1
Compare
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
2 similar comments
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
include/boost/url/impl/url.ipp
Outdated
|
|
||
| return {}; | ||
| dest.copy(base); | ||
| return dest.relative(href); |
There was a problem hiding this comment.
relative is the name? That is kind of obscure... doesn't really suggest what it does. Why are we adding features
There was a problem hiding this comment.
relative is the name? That is kind of obscure... doesn't really suggest what it does.
URL.js uses relative_to. I can't think of anything better than relative/relative_to
Why are we adding features
I don't know. I was assigned this issue and started writing the code at some point.
alandefreitas
force-pushed
the
relative_path
branch
from
f9c5121 to
4c08cca
Compare
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
1 similar comment
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
alandefreitas
force-pushed
the
relative_path
branch
from
4c08cca to
7747e31
Compare
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
1 similar comment
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
|
I rebased this PR and fixed everything that broke with the new containers. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #425 +/- ##
===========================================
+ Coverage 96.81% 96.83% +0.01%
===========================================
Files 139 139
Lines 6691 6847 +156
===========================================
+ Hits 6478 6630 +152
- Misses 213 217 +4
Continue to review full report at Codecov.
|
alandefreitas
force-pushed
the
relative_path
branch
from
5d09d1b to
559dc25
Compare
|
GCOVR code coverage report https://425.url.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
|
GCOVR code coverage report https://425.url.prtest.cppalliance.org/gcovr/index.html |
|
An automated preview of the documentation is available at https://425.url.prtest.cppalliance.org/libs/url/doc/html/index.html |
|
GCOVR code coverage report https://425.url.prtest.cppalliance.org/gcovr/index.html |
fix #407