Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Item offset? Deface #6

Open
salverde opened this issue Aug 15, 2017 · 4 comments
Open

Menu Item offset? Deface #6

salverde opened this issue Aug 15, 2017 · 4 comments

Comments

@salverde
Copy link

Is the Roles supposed to be a sub item under users?

users

Seems like its at the root level. Is this a known issue?

@VitaliyAdamkov
Copy link

VitaliyAdamkov commented Dec 8, 2017

+1
did not figure out, how to make it possible with deface, used that in the initializer:

Spree::Backend::Config.configure do |config|
  # add roles to users admin submenu
  users_menu_index = config.menu_items.index { |i| i.label == :users }
  new_users_menu = config.class::MenuItem.new(
                     config.class::USER_TABS + [:roles],
                     'user',
                     condition: -> { Spree.user_class && can?(:admin, Spree.user_class) },
                     partial: 'spree/admin/shared/user_sub_menu'
                   )
  config.menu_items[users_menu_index] = new_users_menu
end

@memotoro
Copy link
Contributor

Hello @VitaliyAdamkov

I fixed this issue with this pull request (#8). It was merge into master. Just use master version and should be fine.

Regards

@VitaliyAdamkov
Copy link

Beg my pardon, but as i can see, this pull request does not fix the 'Menu Item offset' issue..

@memotoro
Copy link
Contributor

memotoro commented Feb 13, 2018

Hello @VitaliyAdamkov

What I did was to put a fonts awesome icon that pushes the 'Role' word to the right, it makes it aligned with the rest of the menu elements. However, I have the 'Role' menu as an independent module, not as sub-module of the 'Users' as you pointed out (I'm not sure why, I didn't notice that before). That fix worked for me, but you are right about the offset in the sub-module, it is not fixed yet.

Regards

selection_005

ccarruitero pushed a commit to ccarruitero/solidus_user_roles-deprecated that referenced this issue Jul 10, 2024
…ng-at-boot

Force DB connection attempt at gem activation time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants