custom generators can break casual

[psalaets]

Defining a custom generator with specific names can break other casual generators.

Example:

casual.define('letters', n => 'ABC');

// this built-in generator is now broken
casual.letter // => undefined

It only happens for me when custom generator named "letters" and it takes an argument.

[psalaets]

I looked at the code and I think this is happening because the text provider has some helper properties that aren't part of the public api but they do get mixed into the casual object.

[psalaets]

To resolve this we can change providers

+var privateHelper = 'blah';

var provider = {
- privateHelper: 'blah',

  builtInGenerator: function() {
-   return this.privateHelper;
+   return privateHelper;
  }
};

[AncientSwordRage]

Is there any movement on this?

[psalaets]

None as far as I know. I'm just working around it in my project.

…

On Fri, Jun 19, 2020, 7:08 AM Craig ***@***.***> wrote: Is there any movement on this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA6IMA5E2NI2JRSXWYSMF3RXNBJBANCNFSM4DJV365A> .