Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems recording GPU on linux #186

Open
qbojj opened this issue Dec 20, 2022 · 0 comments
Open

Problems recording GPU on linux #186

qbojj opened this issue Dec 20, 2022 · 0 comments

Comments

@qbojj
Copy link
Contributor

qbojj commented Dec 20, 2022

I build optick with OPTICK_USE_VULKAN flag but the CMakeLists.txt does not set OPTICK_ENABLE_GPU_VULKAN=1 (only OPTICK_ENABLE_GPU=1).

When the flag is not set CMakeLists sets OPTICK_ENABLE_GPU_VULKAN=0, but not the other way around, and because in optick.config.h OPTICK_ENABLE_GPU_VULKAN is always set to 0 when it is not __WIN32__ and OPTICK_ENABLE_GPU_VULKAN is not defined, so vulkan is never enabled on platforms other than windows.

The quickest fix (I don't know if it fully works, only tested on my machine and configuration) is to add
target_compile_definitions(OptickCore PRIVATE OPTICK_ENABLE_GPU_VULKAN=0) inside if(OPTICK_USE_VULKAN)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant