Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS EventBridge Support missing #171

Open
Tanish2002 opened this issue Jan 14, 2022 · 2 comments
Open

AWS EventBridge Support missing #171

Tanish2002 opened this issue Jan 14, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Tanish2002
Copy link

Shopify has support for AWS EventBridge(here), which can be used to integrate webhook delivery.

When trying to use the current Create method like this:-

resp, err := c.Webhook.Create(goshopify.Webhook{
	Address: "arn:aws:events:ap-south-1::event-source/aws.partner/shopify.com/xxxxxx7/somecustomrule",
	Topic:   "orders/create",
	Format:  "json",
})

The response received is address: is invalid

The official node api has a DeliveryMethod field

@oliver006 oliver006 added the help wanted Extra attention is needed label Mar 25, 2023
@oliver006
Copy link
Collaborator

The official docs don't mention the DeliveryMethod field:
https://shopify.dev/docs/api/admin-rest/2023-01/resources/webhook

Did you try adding a field to the Webhook struct and see if it works?

@sshaw
Copy link

sshaw commented Dec 8, 2024

I can confirm this works. I use it all the time via Shopify Development Tools CLI. Here's an example: https://github.com/ScreenStaring/shopify-dev-tools/blob/bbc5c8f8ee91bd480aac0db1506db664b63230f0/cmd/webhooks/webhooks.go#L111-L118

I suspect the problem is your case is the hook is not properly configured in Shopify and AWS. I see you have a valid ARN but the process is confusing and I had to do it twice before it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants