Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move make_detector() to conftest.py and refactor tests #233

Open
Tracked by #395
OCopping opened this issue Apr 18, 2024 · 0 comments
Open
Tracked by #395

Move make_detector() to conftest.py and refactor tests #233

OCopping opened this issue Apr 18, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@OCopping
Copy link
Contributor

#219 required make_detector(), however the easiest solution was to copy/paste it directly in to test_protocols.py. In the long run it would be useful to move make_detector() into conftest.py, however this will require refactoring of all other tests that use it too.
@OCopping OCopping added enhancement New feature or request good first issue Good for newcomers labels Apr 18, 2024
@coretl coretl mentioned this issue Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OCopping