Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite cursor timeout in tests #807

Open
padraic-shafer opened this issue Apr 25, 2024 · 2 comments
Open

SQLite cursor timeout in tests #807

padraic-shafer opened this issue Apr 25, 2024 · 2 comments

Comments

@padraic-shafer
Copy link
Contributor

I occasionally see timeouts in unit tests run on GitHub, stemming from the sqlite module. I'm not sure whether we simply need to increase the timeout for these tests, or if there is something more subtle like a race condition between tests using the db.

success = finished_event.wait(timeout=.1)
if not success:
raise TimeoutError("{key} call timed out".format(key=key))

The failures are infrequent, but could be suggestive of being "on the edge" of an instability that might be triggered by the timing of usage on systems in the wild.

@danielballan
Copy link
Member

The SQLite usage here is coming from a databroker backend that was experimental in ~2015 and never used on the floor at NSLS-II (or anywhere else, to my knowledge). There is a strong aversion to deleting any code from this project, but perhaps we could xfail these tests….

@padraic-shafer
Copy link
Contributor Author

Or mark them as flaky?
https://docs.pytest.org/en/latest/explanation/flaky.html#plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants