Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle v4 ASCII option types #52

Open
leshow opened this issue Jan 12, 2023 · 0 comments
Open

Handle v4 ASCII option types #52

leshow opened this issue Jan 12, 2023 · 0 comments

Comments

@leshow
Copy link
Collaborator

leshow commented Jan 12, 2023

In #42 we discussed how some types, like Message are currently String but that type is perhaps too permissive when encoding. We have a few options to deal with this:

  • use Vec<u8> everywhere
  • use a type like BString to give a string-like api while maintaining that it is just a vec of bytes in memory
  • non-type system solution, using comments?
@leshow leshow changed the title Handle v4 ASCII types Handle v4 ASCII option types Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant