Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering in close corners #25

Closed
katexochen opened this issue Oct 29, 2023 · 3 comments
Closed

Rendering in close corners #25

katexochen opened this issue Oct 29, 2023 · 3 comments
Assignees
@dmullis
Labels
bug

Comments

@katexochen
Copy link

katexochen commented Oct 29, 2023 •
edited
Loading

Sometimes corners that are close to each other cannot be rendered as desired:

The following is kind of expected:

+----------+
|  PCRn    |
+----------+
+----------+
| Nonce    |
+----------+

image

It would be great if using other corners would not connect the two boxes:

+----------+
|  PCRn    |
'----------'
.----------.
| Nonce    |
+----------+

but it currently renders the same as with +
dmullis pushed a commit to dmullis/goat that referenced this issue Feb 15, 2024
Expose issue blampe#25
c2fa139
dmullis pushed a commit to dmullis/goat that referenced this issue Feb 20, 2024
Fix blampe issue blampe#25: "Rendering in close corners"
496b38b 
For result, see examples/small-grids.svg

blampe#25
@dmullis
Copy link
Collaborator

dmullis commented Feb 20, 2024

See fix referenced above.

@dmullis
Copy link
Collaborator

dmullis commented Jun 11, 2024 •
edited
Loading

Fix mentioned above will be preserved in https://github.com/dmullis/goat/tree/github-test rather than in the main branch of my fork.

@dmullis dmullis self-assigned this Jun 22, 2024
@dmullis dmullis added the bug label Jun 22, 2024
dmullis pushed a commit to dmullis/goat that referenced this issue Jun 22, 2024
Expose issue blampe#25
047f25c
dmullis pushed a commit to dmullis/goat that referenced this issue Jul 2, 2024
Issue blampe#25 -- Vertical edges of boxes run together
7b1281f 
Regression Testing
---
Ran ./pre-push: SVG output of three files changed.  Log excerpt:

    === RUN   TestExamples
        ...
        examples-regression_test.go:83: Failed to verify contents of 3 .svg files
        examples-regression_test.go:130: Writing new SVG and HTML delta files into _examples_new/
        examples-regression_test.go:149: 	complicated.html
        examples-regression_test.go:149: 	regression.html
        examples-regression_test.go:149: 	small-grids.html
        ...

Visual inspection of .html files in browser shows fix effective in
_examples_new/small-grids.{html,svg}, and no visually apparent change
in the other two sets of results.
@dmullis dmullis mentioned this issue Jul 2, 2024
Closed
@dmullis dmullis linked a pull request Jul 2, 2024 that will close this issue
Fix Issue #25 #34
Closed
dmullis pushed a commit that referenced this issue Jul 17, 2024
@dmullis
Expose issue #25
b13d251
dmullis pushed a commit to dmullis/goat that referenced this issue Jul 17, 2024
Issue blampe#25 -- Vertical edges of boxes run together
b2022b0 
Regression Testing
---
Ran ./pre-push: SVG output of three files changed.  Log excerpt:

    === RUN   TestExamples
        ...
        examples-regression_test.go:83: Failed to verify contents of 3 .svg files
        examples-regression_test.go:130: Writing new SVG and HTML delta files into _examples_new/
        examples-regression_test.go:149: 	complicated.html
        examples-regression_test.go:149: 	regression.html
        examples-regression_test.go:149: 	small-grids.html
        ...

Visual inspection of .html files in browser shows fix effective in
_examples_new/small-grids.{html,svg}, and no visually apparent change
in the other two sets of results.
@dmullis dmullis mentioned this issue Jul 17, 2024
Merged
dmullis pushed a commit that referenced this issue Jul 17, 2024
@dmullis
Issue #25 -- Vertical edges of boxes run together
d30858a 
Regression Testing
---
Ran ./pre-push: SVG output of three files changed.  Log excerpt:

    === RUN   TestExamples
        ...
        examples-regression_test.go:83: Failed to verify contents of 3 .svg files
        examples-regression_test.go:130: Writing new SVG and HTML delta files into _examples_new/
        examples-regression_test.go:149: 	complicated.html
        examples-regression_test.go:149: 	regression.html
        examples-regression_test.go:149: 	small-grids.html
        ...

Visual inspection of .html files in browser shows fix effective in
_examples_new/small-grids.{html,svg}, and no visually apparent change
in the other two sets of results.
@dmullis
Copy link
Collaborator

dmullis commented Jul 17, 2024

Fixed in
a4c2da8

@dmullis dmullis closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmullis dmullis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Issue #25 dmullis/goat
2 participants
@dmullis @katexochen