Invalid error message alignment

[koral--]

The last warning is red, while fatal error is white.

It seems that first line of the output from 3rd attempt is printed red as an overall result and the next line is not coloured.
Maybe all the overall error message should be red?

Screenshot contents is produced by version 3.5.1 of the step however, I haven't found anything related in release notes at: https://github.com/bitrise-io/steps-git-clone/releases

[viktorbenei]

v4 includes tons of changes (was pretty much a complete rewrite), so could you please try it again with the latest version of the step @koral-- ?

[koral--]

Here is how it looks like on 4.0.4 (error I simulated is a little bit different but it doesn't matter):

Coloring seems to be fine but yellow text is not properly aligned vertically. Highlighted text appears 2 times in area of Attempt 2 but not once in Attempt 1.

[viktorbenei]

@koral-- thanks for the report & screen shot!

Re:

Coloring seems to be fine but yellow text is not properly aligned vertically. Highlighted text appears 2 times in area of Attempt 2 but not once in Attempt 1.

That's not the fault of the step directly, it affects Bitrise logs sometimes if stdout and stderr are both written at about the same time on Linux.

We're still searching for exactly what might cause this, and we only saw this happening on Linux; most likely some kind of stderr buffering delay is the root cause as technically we just use Go's built in "Combined Output" method, which returns both the stdout and stderr in the same string/buffer.

That issue is tracked at bitrise-io/bitrise#546 (was also reported by you ;) ), so I'll close this issue here, but feel free to comment if we missed anything and we'll reopen it :)